Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit a6b5801

Browse files
gkalpakpetebacondarwin
authored andcommitted
refactor(test/e2e): remove explicit call to waitForAngular()
Protractor automatically calls `waitForAngular()`, before every WebDriver action. Closes #14920
1 parent 38fd896 commit a6b5801

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

test/e2e/tests/angular-already-loadedSpec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
describe('App where angular is loaded more than once', function() {
22
beforeEach(function() {
3-
loadFixture('angular-already-loaded').andWaitForAngular();
3+
loadFixture('angular-already-loaded');
44
});
55

66
it('should have the interpolated text', function() {

test/e2e/tests/helpers/main.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
var helper = {
2-
andWaitForAngular: function() {
3-
browser.waitForAngular();
4-
},
52
loadFixture: function(fixture) {
63
var i = 0;
74
while (fixture[i] === '/') ++i;

test/e2e/tests/loaderSpec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
describe('angular-loader', function() {
22
beforeEach(function() {
3-
loadFixture('loader').andWaitForAngular();
3+
loadFixture('loader');
44
});
55

66
it('should not be broken by loading the modules before core', function() {

test/e2e/tests/ngJqSpec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
describe('Customizing the jqLite / jQuery version', function() {
22
it('should be able to force jqLite', function() {
3-
loadFixture('ngJq').andWaitForAngular();
3+
loadFixture('ngJq');
44
expect(element(by.binding('jqueryVersion')).getText()).toBe('jqLite');
55
});
66

77
it('should be able to use a specific version jQuery', function() {
8-
loadFixture('ngJqJquery').andWaitForAngular();
8+
loadFixture('ngJqJquery');
99
expect(element(by.binding('jqueryVersion')).getText()).toBe('2.1.0');
1010
});
1111
});

test/e2e/tests/sampleSpec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Sample E2E test:
22
describe('Sample', function() {
33
beforeEach(function() {
4-
loadFixture('sample').andWaitForAngular();
4+
loadFixture('sample');
55
});
66

77
it('should have the interpolated text', function() {

0 commit comments

Comments
 (0)