refactor(ngAnimate): simplify closeChildAnimations() and remove redundant calls

gkalpak · gkalpak · commit a4d4d3cfb079 · 2016-12-15T15:27:33.000+02:00
diff --git a/src/ngAnimate/animateQueue.js b/src/ngAnimate/animateQueue.js
@@ -393,7 +393,7 @@ var $$AnimateQueueProvider = ['$animateProvider', /** @this */ function($animate
       }
 
       if (isStructural) {
-        closeChildAnimations(element);
+        closeChildAnimations(node);
       }
 
       var newAnimation = {
@@ -585,8 +585,7 @@ var $$AnimateQueueProvider = ['$animateProvider', /** @this */ function($animate
       }
     }
 
-    function closeChildAnimations(element) {
-      var node = getDomNode(element);
+    function closeChildAnimations(node) {
       var children = node.querySelectorAll('[' + NG_ANIMATE_ATTR_NAME + ']');
       forEach(children, function(child) {
         var state = parseInt(child.getAttribute(NG_ANIMATE_ATTR_NAME), 10);

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ var $$AnimateQueueProvider = ['$animateProvider', /** @this */ function($animate`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`if (isStructural) {`
`396`		`- closeChildAnimations(element);`
	`396`	`+ closeChildAnimations(node);`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`var newAnimation = {`
`@@ -585,8 +585,7 @@ var $$AnimateQueueProvider = ['$animateProvider', /** @this */ function($animate`
`585`	`585`	`}`
`586`	`586`	`}`
`587`	`587`
`588`		`- function closeChildAnimations(element) {`
`589`		`- var node = getDomNode(element);`
	`588`	`+ function closeChildAnimations(node) {`
`590`	`589`	`var children = node.querySelectorAll('[' + NG_ANIMATE_ATTR_NAME + ']');`
`591`	`590`	`forEach(children, function(child) {`
`592`	`591`	`var state = parseInt(child.getAttribute(NG_ANIMATE_ATTR_NAME), 10);`