Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit a03b75c

Browse files
jbedardNarretz
authored andcommitted
refactor($browser): remove workaround for old ff bug
- https://bugzilla.mozilla.org/show_bug.cgi?id=407172 was fixed in ff 40 Closes #16065
1 parent e58bcfa commit a03b75c

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

src/ng/browser.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,7 @@ function Browser(window, document, $log, $sniffer) {
173173
// - pendingLocation is needed as browsers don't allow to read out
174174
// the new location.href if a reload happened or if there is a bug like in iOS 9 (see
175175
// https://openradar.appspot.com/22186109).
176-
// - the replacement is a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=407172
177-
return pendingLocation || location.href.replace(/%27/g,'\'');
176+
return pendingLocation || location.href;
178177
}
179178
};
180179

test/ng/browserSpecs.js

-5
Original file line numberDiff line numberDiff line change
@@ -383,11 +383,6 @@ describe('browser', function() {
383383
expect(browser.url('http://any.com', true, state).url('http://any.com', true, state)).toBe(browser);
384384
});
385385

386-
it('should decode single quotes to work around FF bug 407273', function() {
387-
fakeWindow.location.href = 'http://ff-bug/?single%27quote';
388-
expect(browser.url()).toBe('http://ff-bug/?single\'quote');
389-
});
390-
391386
it('should not set URL when the URL is already set', function() {
392387
var current = fakeWindow.location.href;
393388
sniffer.history = false;

0 commit comments

Comments
 (0)