Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 9221628

Browse files
hzoocaitp
authored andcommitted
style(*): add rule disallowSpacesInFunctionDeclaration beforeOpeningRoundBrace
1 parent 655fccc commit 9221628

File tree

7 files changed

+13
-8
lines changed

7 files changed

+13
-8
lines changed

.jscs.json

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
"disallowSpaceAfterObjectKeys": true,
77
"disallowSpaceAfterPrefixUnaryOperators": ["!"],
88
"disallowSpaceBeforeBinaryOperators": [","],
9+
"disallowSpacesInFunctionDeclaration": {
10+
"beforeOpeningRoundBrace": true
11+
},
912
"disallowSpacesInNamedFunctionExpression": {
1013
"beforeOpeningRoundBrace": true
1114
},

src/ng/directive/ngClass.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ function classDirective(name, selector) {
3838
attr.$removeClass(newClasses);
3939
}
4040

41-
function digestClassCounts (classes, count) {
41+
function digestClassCounts(classes, count) {
4242
var classCounts = element.data('$classCounts') || {};
4343
var classesToUpdate = [];
4444
forEach(classes, function (className) {
@@ -53,7 +53,7 @@ function classDirective(name, selector) {
5353
return classesToUpdate.join(' ');
5454
}
5555

56-
function updateClasses (oldClasses, newClasses) {
56+
function updateClasses(oldClasses, newClasses) {
5757
var toAdd = arrayDifference(newClasses, oldClasses);
5858
var toRemove = arrayDifference(oldClasses, newClasses);
5959
toAdd = digestClassCounts(toAdd, 1);
@@ -95,7 +95,7 @@ function classDirective(name, selector) {
9595
return values;
9696
}
9797

98-
function arrayClasses (classVal) {
98+
function arrayClasses(classVal) {
9999
if (isArray(classVal)) {
100100
return classVal;
101101
} else if (isString(classVal)) {

src/ng/location.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ function LocationHashbangUrl(appBase, hashPrefix) {
206206
* Inside of Angular, we're always using pathnames that
207207
* do not include drive names for routing.
208208
*/
209-
function removeWindowsDriveName (path, url, base) {
209+
function removeWindowsDriveName(path, url, base) {
210210
/*
211211
Matches paths for file protocol on windows,
212212
such as /C:/foo/bar, and captures only /foo/bar.

src/ngAria/aria.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,11 @@ ngAriaModule.directive('ngShow', ['$aria', function($aria) {
139139
}])
140140
.directive('ngModel', ['$aria', function($aria) {
141141

142-
function shouldAttachAttr (attr, elem) {
142+
function shouldAttachAttr(attr, elem) {
143143
return $aria.config(attr) && !elem.attr(attr);
144144
}
145145

146-
function getShape (attr, elem) {
146+
function getShape(attr, elem) {
147147
var type = attr.type,
148148
role = attr.role;
149149

test/auto/injectorSpec.js

+2
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ describe('injector', function() {
162162

163163
it('should create $inject', function() {
164164
var extraParans = angular.noop;
165+
// jscs:disable disallowSpacesInFunctionDeclaration
165166
// keep the multi-line to make sure we can handle it
166167
function $f_n0 /*
167168
*/(
@@ -172,6 +173,7 @@ describe('injector', function() {
172173
*/
173174
_c,
174175
/* {some type} */ d) { extraParans();}
176+
// jscs:enable disallowSpacesInFunctionDeclaration
175177
expect(annotate($f_n0)).toEqual(['$a', 'b_', '_c', 'd']);
176178
expect($f_n0.$inject).toEqual(['$a', 'b_', '_c', 'd']);
177179
});

test/ng/compileSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1605,7 +1605,7 @@ describe('$compile', function() {
16051605
describe('delay compile / linking functions until after template is resolved', function(){
16061606
var template;
16071607
beforeEach(module(function() {
1608-
function logDirective (name, priority, options) {
1608+
function logDirective(name, priority, options) {
16091609
directive(name, function(log) {
16101610
return (extend({
16111611
priority: priority,

test/ngAria/ariaSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ function expectAriaAttrOnEachElement(elem, ariaAttr, expected) {
499499
});
500500
}
501501

502-
function configAriaProvider (config) {
502+
function configAriaProvider(config) {
503503
return function() {
504504
angular.module('ariaTest', ['ngAria']).config(function($ariaProvider) {
505505
$ariaProvider.config(config);

0 commit comments

Comments
 (0)