Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 9019c2d

Browse files
committed
test(e2e): fix e2e tests in Firefox
1 parent 83a12a5 commit 9019c2d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/ng/directive/input.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -1018,13 +1018,16 @@ var inputType = {
10181018
</file>
10191019
<file name="protractor.js" type="protractor">
10201020
it('should change state', function() {
1021+
var inputs = element.all(by.model('color.name'));
10211022
var color = element(by.binding('color.name'));
10221023
10231024
expect(color.getText()).toContain('blue');
10241025
1025-
element.all(by.model('color.name')).get(0).click();
1026-
1026+
inputs.get(0).click();
10271027
expect(color.getText()).toContain('red');
1028+
1029+
inputs.get(1).click();
1030+
expect(color.getText()).toContain('green');
10281031
});
10291032
</file>
10301033
</example>

test/e2e/tests/anchor-scroll.spec.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ describe('$anchorScroll', function() {
2525
pass: browser.driver.
2626
executeScript(_script_getTop, id).
2727
then(function(actualTop) {
28-
var passed = actualTop === expectedTop;
28+
// Some browsers may report have +/-1 pixel deviation
29+
var passed = Math.abs(expectedTop - actualTop) <= 1;
2930
result.message = 'Expected #' + id + '\'s top' + (passed ? ' not' : '') +
3031
' to be ' + expectedTop + ', but it was ' + actualTop;
3132
return passed;

0 commit comments

Comments
 (0)