Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 8d9984e

Browse files
committed
chore(docs-gen): generate list of versions in correct order
Closes #16419
1 parent 1d80464 commit 8d9984e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

docs/config/processors/versions-data.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ module.exports = function generateVersionDocProcessor(gitData) {
5555

5656
if (missesCurrentVersion) versions.push(currentVersion.version);
5757

58-
// Get the stable release with the highest version
59-
var highestStableRelease = versions.reverse().find(semverIsStable);
60-
6158
versions = versions
6259
.filter(function(versionStr) {
6360
return blacklist.indexOf(versionStr) === -1;
@@ -85,6 +82,9 @@ module.exports = function generateVersionDocProcessor(gitData) {
8582
var latest = sortObject(latestMap, reverse(semver.compare))
8683
.map(function(version) { return makeOption(version, 'Latest'); });
8784

85+
// Get the stable release with the highest version
86+
var highestStableRelease = versions.find(semverIsStable);
87+
8888
// Generate master and stable snapshots
8989
var snapshots = [
9090
makeOption(
@@ -130,14 +130,15 @@ module.exports = function generateVersionDocProcessor(gitData) {
130130
return Object.keys(obj).map(function(key) { return obj[key]; }).sort(cmp);
131131
}
132132

133+
// Adapted from
133134
// https://github.com/kaelzhang/node-semver-stable/blob/34dd29842409295d49889d45871bec55a992b7f6/index.js#L25
134135
function semverIsStable(version) {
135-
var semverObj = semver.parse(version);
136+
var semverObj = version.version;
136137
return semverObj === null ? false : !semverObj.prerelease.length;
137138
}
138139

139140
function createSnapshotStableLabel(version) {
140-
var label = 'v' + version.replace(/.$/, 'x') + '-snapshot';
141+
var label = version.label.replace(/.$/, 'x') + '-snapshot';
141142

142143
return label;
143144
}

0 commit comments

Comments
 (0)