Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 866df9d

Browse files
committed
chore(ci): fix deploy-code CI job
In #17060, the `deploy-code` job was updated to [include][1] the `init_environment` step. This step assumes that the working directory is `~/ng`. The `deploy-code` job uses the `cloud-sdk`, which [did not specify a working directory][2]. As a result, the `init_environment` step and subsequently the `deploy-code` job failed. Examples failures: [on master][3], [on v1.8.x][4] This commit fixes the issue by specifying a working directory for the `cloud-sdk` executor. It also updates paths used in other steps of the `deploy-code` job to take the working directory into account. [1]: https://github.com/angular/angular.js/blob/83f084e5db95768dcee5302fa77924e1fb1f3239/.circleci/config.yml#L359 [2]: https://github.com/angular/angular.js/blob/83f084e5db95768dcee5302fa77924e1fb1f3239/.circleci/config.yml#L34-L37 [3]: https://app.circleci.com/pipelines/github/angular/angular.js/152/workflows/812df7b2-4bba-4e9e-a868-8c58db5d40d1/jobs/1594 [4]: https://app.circleci.com/pipelines/github/angular/angular.js/153/workflows/6a9826ac-d191-4042-8c39-0c969c81e381/jobs/1607
1 parent 83f084e commit 866df9d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.circleci/config.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ executors:
3535
description: The docker container to use when running gcp-gcs commands
3636
docker:
3737
- image: google/cloud-sdk:alpine@sha256:7d0cae28cb282b76f2d9babe278c63c910d54f0cceca7a65fdf6806e2b43882e
38+
working_directory: ~/ng
3839

3940

4041
# Filter Definitions
@@ -358,7 +359,7 @@ jobs:
358359
- custom_attach_workspace
359360
- init_environment
360361
- skip_unless_tag_or_master_or_stable_branch
361-
- run: ls ~/ng/deploy/code
362+
- run: ls deploy/code
362363
- run:
363364
name: Authenticate and configure Docker
364365
command: |
@@ -367,7 +368,7 @@ jobs:
367368
- run:
368369
name: Sync files to code.angularjs.org
369370
command: |
370-
gsutil -m rsync -r ~/ng/deploy/code gs://code-angularjs-org-338b8.appspot.com
371+
gsutil -m rsync -r deploy/code gs://code-angularjs-org-338b8.appspot.com
371372
372373
# The `deploy-docs` job should only run when all of these conditions are true for the build:
373374
# - It is for the `angular/angular.js` repository (not a fork).

0 commit comments

Comments
 (0)