fixup

Author: Narretz

src/ngMessages/messages.js

@@ -654,7 +654,7 @@ function ngMessageDirectiveFactory() {
           assignRecords(staticExp);
         }
 
-        var currentElement, currentScope, messageCtrl;
+        var currentElement, messageCtrl;
         ngMessagesCtrl.register(commentNode, messageCtrl = {
           test: function(name) {
             return contains(records, name);
@@ -664,7 +664,6 @@ function ngMessageDirectiveFactory() {
               $transclude(function(elm, newScope) {
                 $animate.enter(elm, null, element);
                 currentElement = elm;
-                currentScope = newScope;
 
                 // Each time we attach this node to a message we get a new id that we can match
                 // when we are destroying the node later.
@@ -678,6 +677,7 @@ function ngMessageDirectiveFactory() {
                     ngMessagesCtrl.deregister(commentNode);
                     messageCtrl.detach();
                   }
+                  newScope.$destroy();
                 });
               });
             }
@@ -687,8 +687,6 @@ function ngMessageDirectiveFactory() {
               var elm = currentElement;
               currentElement = null;
               $animate.leave(elm);
-              currentScope && currentScope.$destroy();
-              currentScope = null;
             }
           }
         });

test/ngMessages/messagesSpec.js

@@ -1,6 +1,6 @@
 'use strict';
 
-fdescribe('ngMessages', function() {
+describe('ngMessages', function() {
   beforeEach(inject.strictDi());
   beforeEach(module('ngMessages'));
 
@@ -488,23 +488,6 @@ fdescribe('ngMessages', function() {
 
   it('should clean-up the ngMessage scope when a message is removed',
     inject(function($compile, $rootScope) {
-      function countWatchers() {
-        var scope = $rootScope;
-        var watchers = 0;
-
-        while (scope) {
-          watchers += scope.$$watchers.length;
-          if (scope.$$childHead) {
-            scope = scope.$$childHead;
-          } else if (scope.$$nextSibling) {
-            scope = scope.$$nextSibling;
-          } else {
-            scope = null;
-          }
-        }
-
-        return watchers;
-      }
 
       var html =
           '<div ng-messages="items">' +
@@ -518,14 +501,14 @@ fdescribe('ngMessages', function() {
       });
 
       expect(element.text()).toBe('A');
-      var watchers = countWatchers();
+      var watchers = $rootScope.$countWatchers();
 
       $rootScope.$apply('items.a = false');
 
       expect(element.text()).toBe('');
       // We don't know exactly how many watchers are on the scope, only that there should be
       // one less now
-      expect(countWatchers()).toBe(watchers-1);
+      expect($rootScope.$countWatchers()).toBe(watchers-1);
     })
   );