refactor

Author: Narretz

src/ngSanitize/filter/linky.js

@@ -165,18 +165,18 @@ angular.module('ngSanitize').filter('linky', ['$sanitize', function($sanitize) {
 
     function addLink(url, text) {
       var key;
-      var computedAttributes = {};
       html.push('<a ');
       if (angular.isFunction(attributes)) {
         attributes = attributes(url);
       }
       if (angular.isObject(attributes)) {
-        computedAttributes = attributes;
-        for (key in computedAttributes) {
-          html.push(key + '="' + computedAttributes[key] + '" ');
+        for (key in attributes) {
+          html.push(key + '="' + attributes[key] + '" ');
         }
+      } else {
+        attributes = {};
       }
-      if (angular.isDefined(target) && !('target' in computedAttributes)) {
+      if (angular.isDefined(target) && !('target' in attributes)) {
         html.push('target="',
                   target,
                   '" ');

test/ngSanitize/filter/linkySpec.js

@@ -86,7 +86,7 @@ describe('linky', function() {
 
     it('should strip unsafe attributes', function() {
       expect(linky("http://example.com", "_self", {"class" : "blue", "onclick": "alert('Hi')"})).
-        toEqual('<a target="_self" class="blue" href="http://example.com">http://example.com</a>');
+        toEqual('<a class="blue" target="_self" href="http://example.com">http://example.com</a>');
     });
   });
 });