Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 759fdcd

Browse files
committed
perf(select): don't prepend unknown option if already prepended
1 parent 3fdf907 commit 759fdcd

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/ng/directive/select.js

+8
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ var SelectController =
3636
$element.val(unknownVal);
3737
};
3838

39+
self.updateUnknownOption = function(val) {
40+
var unknownVal = '? ' + hashKey(val) + ' ?';
41+
self.unknownOption.val(unknownVal);
42+
$element.val(unknownVal);
43+
};
44+
3945
$scope.$on('$destroy', function() {
4046
// disable unknown option so that we don't do work when the whole select is being destroyed
4147
self.renderUnknownOption = noop;
@@ -74,6 +80,8 @@ var SelectController =
7480
if (value == null && self.emptyOption) {
7581
self.removeUnknownOption();
7682
$element.val('');
83+
} else if (self.unknownOption.parent().length) {
84+
self.updateUnknownOption(value);
7785
} else {
7886
self.renderUnknownOption(value);
7987
}

0 commit comments

Comments
 (0)