Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 738af0b

Browse files
committed
perf(select): don't prepend unknown option if already prepended
1 parent ae1ffdc commit 738af0b

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/ng/directive/select.js

+8
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,12 @@ var SelectController =
3838
$element.val(unknownVal);
3939
};
4040

41+
self.updateUnknownOption = function(val) {
42+
var unknownVal = '? ' + hashKey(val) + ' ?';
43+
self.unknownOption.val(unknownVal);
44+
$element.val(unknownVal);
45+
};
46+
4147
$scope.$on('$destroy', function() {
4248
// disable unknown option so that we don't do work when the whole select is being destroyed
4349
self.renderUnknownOption = noop;
@@ -80,6 +86,8 @@ var SelectController =
8086
if (value == null && self.emptyOption) {
8187
self.removeUnknownOption();
8288
$element.val('');
89+
} else if (self.unknownOption.parent().length) {
90+
self.updateUnknownOption(value);
8391
} else {
8492
self.renderUnknownOption(value);
8593
}

0 commit comments

Comments
 (0)