fixup! feat($compile): add support for arbitrary property and event bindings

Author: jbedard

docs/content/error/$compile/ctxoverride.ngdoc

@@ -0,0 +1,13 @@
+@ngdoc error
+@name $compile:ctxoverride
+@fullName Context Override
+@description
+
+This error occurs when the security context for an attribute is defined multiple times under different security contexts.
+
+For example:
+
+```
+$compileProvider.addPropertyContext("my-element", "src", "mediaUrl");
+$compileProvider.addPropertyContext("my-element", "src", "resourceUrl");    //throws
+```

src/ng/compile.js

@@ -1606,7 +1606,13 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    * @param {string} ctx the context type
    */
   this.addPropertyContext = function(elementName, propertyName, ctx) {
-    PROP_CONTEXTS[(elementName.toLowerCase() + '|' + propertyName.toLowerCase())] = ctx;
+    var key = (elementName.toLowerCase() + '|' + propertyName.toLowerCase());
+
+    if (key in PROP_CONTEXTS && PROP_CONTEXTS[key] !== ctx) {
+      throw $compileMinErr('ctxoverride', 'Property context \'{0}.{1}\' already set to \'{2}\', cannot override to \'{3}\'.', elementName, propertyName, PROP_CONTEXTS[key], ctx);
+    }
+
+    PROP_CONTEXTS[key] = ctx;
   };
 
   /* Default property contexts.

test/ng/compileSpec.js

@@ -12678,6 +12678,47 @@ describe('$compile', function() {
     });
   });
 
+  describe('addPropertyContext', function() {
+    function testProvider(provider) {
+      module(provider);
+      inject(function($compile) { /* done! */});
+    }
+
+    it('should allow adding new properties', function() {
+      testProvider(function($compileProvider) {
+        $compileProvider.addPropertyContext('div', 'title', 'mediaUrl');
+        $compileProvider.addPropertyContext('*', 'my-prop', 'resourceUrl');
+      });
+    });
+
+    it('should allow different sce types of a property on different element types', function() {
+      testProvider(function($compileProvider) {
+        $compileProvider.addPropertyContext('div', 'title', 'mediaUrl');
+        $compileProvider.addPropertyContext('span', 'title', 'css');
+        $compileProvider.addPropertyContext('*', 'title', 'resourceUrl');
+        $compileProvider.addPropertyContext('article', 'title', 'html');
+      });
+    });
+
+    it('should throw \'ctxoverride\' when changing an existing context', function() {
+      testProvider(function($compileProvider) {
+        $compileProvider.addPropertyContext('div', 'title', 'mediaUrl');
+
+        expect(function() {
+          $compileProvider.addPropertyContext('div', 'title', 'resourceUrl');
+        })
+        .toThrowMinErr('$compile', 'ctxoverride', 'Property context \'div.title\' already set to \'mediaUrl\', cannot override to \'resourceUrl\'.');
+      });
+    });
+
+    it('should setting the same property/element to the same value', function() {
+      testProvider(function($compileProvider) {
+        $compileProvider.addPropertyContext('div', 'title', 'mediaUrl');
+        $compileProvider.addPropertyContext('div', 'title', 'mediaUrl');
+      });
+    });
+  });
+
 
   describe('when an attribute has an underscore-separated name', function() {