Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 618a2b4

Browse files
committed
ie fixes
1 parent 8e1b670 commit 618a2b4

File tree

4 files changed

+27
-8
lines changed

4 files changed

+27
-8
lines changed

src/Angular.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,10 @@ function isElement(node) {
118118
}
119119

120120
function isVisible(element) {
121-
var rect = element[0].getBoundingClientRect();
122-
return rect.width && rect.height;
121+
var rect = element[0].getBoundingClientRect(),
122+
width = rect.width || (rect.right||0 - rect.left||0),
123+
height = rect.height || (rect.bottom||0 - rect.top||0);
124+
return width>0 && height>0;
123125
}
124126

125127
function map(obj, iterator, context) {

src/jqLite.js

+19-3
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ JQLite.prototype = {
100100
});
101101
},
102102

103-
//TODO: remove
104103
trigger: function(type) {
105104
var evnt = document.createEvent('MouseEvent');
106105
evnt.initMouseEvent(type, true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
@@ -191,9 +190,9 @@ JQLite.prototype = {
191190

192191
text: function(value) {
193192
if (isDefined(value)) {
194-
this[0].nodeValue = value;
193+
this[0].textContent = value;
195194
}
196-
return this[0].nodeValue;
195+
return this[0].textContent;
197196
},
198197

199198
val: function(value) {
@@ -216,3 +215,20 @@ JQLite.prototype = {
216215
parent: function() { return jqLite(this[0].parentNode);},
217216
clone: function() { return jqLite(this[0].cloneNode(true)); }
218217
};
218+
219+
if (msie) {
220+
extend(JQLite.prototype, {
221+
text: function(value) {
222+
var e = this[0];
223+
if (isDefined(value)) {
224+
e.innerText = value;
225+
}
226+
// NodeType == 3 is text node
227+
return e.nodeType == 3 ? e.nodeValue : e.innerText;
228+
},
229+
230+
trigger: function(type) {
231+
this[0].fireEvent('on' + type);
232+
}
233+
});
234+
};

test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
java -jar lib/jstestdriver/JsTestDriver.jar --tests BinderTest.testChangingSelectNonSelectedUpdatesModel
1+
java -jar lib/jstestdriver/JsTestDriver.jar --tests BinderTest

test/testabilityPatch.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ function sortedHtml(element) {
7777
for(var css in node.style){
7878
var value = node.style[css];
7979
if (isString(value) && isString(css) && css != 'cssText' && value && (1*css != css)) {
80-
var text = css + ': ' + node.style[css];
81-
if (indexOf(style, text) == -1) {
80+
var value = node.style[css];
81+
var text = css + ': ' + value;
82+
if (value != 'false' && indexOf(style, text) == -1) {
8283
style.push(text);
8384
}
8485
}

0 commit comments

Comments
 (0)