Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 5fc9933

Browse files
committed
fix(jenkins): Fix the format for passing parameters to Grunt tasks
The Jenkins build.sh script has to be updated as the previous way of specifying parameters to the code run in Grunt tasks stopped working with the newest Grunt. This has been previously fixed for the Travis build.sh but wasn't done for the Jenkins one. Also, the contribute docs were updated to account for the new format.
1 parent c322032 commit 5fc9933

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/content/misc/contribute.ngdoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ grunt test:unit
139139
To run the tests on other browsers (Chrome, ChromeCanary, Firefox, Opera and Safari are pre-configured) use:
140140

141141
```shell
142-
grunt test:unit --browsers Opera,Firefox
142+
grunt test:unit --browsers=Opera,Firefox
143143
```
144144

145145
Note there should be _no spaces between browsers_. `Opera, Firefox` is INVALID.

scripts/jenkins/build.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ grunt ci-checks package --no-color
2828
mkdir -p test_out
2929

3030
# UNIT TESTS #
31-
grunt test:unit --browsers $BROWSERS --reporters=dots,junit --no-colors --no-color
31+
grunt test:unit --browsers="$BROWSERS" --reporters=dots,junit --no-colors --no-color
3232

3333
# END TO END TESTS #
3434
grunt test:ci-protractor
3535

3636
# DOCS APP TESTS #
37-
grunt test:docs --browsers $BROWSERS --reporters=dots,junit --no-colors --no-color
37+
grunt test:docs --browsers="$BROWSERS" --reporters=dots,junit --no-colors --no-color
3838

3939
# Promises/A+ TESTS #
4040
grunt test:promises-aplus --no-color

0 commit comments

Comments
 (0)