Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 4b49c31

Browse files
committed
- More fixes as per CR
1 parent 9d842a1 commit 4b49c31

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/ng/compile.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -781,8 +781,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
781781

782782
function assertValidDirectiveName(name) {
783783
var letter = name.charAt(0);
784-
if (letter && (letter !== lowercase(letter))) {
785-
throw ngMinErr('badname', "Directive '{0}' is invalid. The first letter of a directive must be a lowercase letter");
784+
if (letter || letter !== lowercase(letter)) {
785+
throw ngMinErr('badname', "Directive name '{0}' is invalid. The first letter of a directive must be a lowercase letter");
786786
}
787787
return name;
788788
}

test/ng/compileSpec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ describe('$compile', function() {
149149
describe('configuration', function() {
150150

151151
it('should fail to register a directive that does not start with a lowercase letter', function() {
152-
module(function($provide, $compileProvider) {
152+
module(function($compileProvider) {
153153
expect($compileProvider.directive('BadDirectiveName', function() {
154154
return {};
155-
})).toThrowMinErr('badname', "Directive 'BadDirectiveName' is invalid. The first letter of a directive must be a lowercase letter");
155+
})).toThrowMinErr('badname', "Directive name 'BadDirectiveName' is invalid. The first letter of a directive must be a lowercase letter");
156156
});
157157
});
158158

0 commit comments

Comments
 (0)