Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 3d35d16

Browse files
committed
WIP: fix multiple select with select as
1 parent fcde331 commit 3d35d16

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/ng/directive/select.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,8 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) {
399399
optionGroup = optionGroupsCache[groupIndex];
400400

401401
for(index = 1, length = optionGroup.length; index < length; index++) {
402-
if ((optionElement = optionGroup[index].element)[0].selected) {
402+
//Have to use attr because element[0].selected returns false when multiple selected
403+
if ((optionElement = optionGroup[index].element).attr('selected')) {
403404
key = optionElement.val();
404405
if (keyName) locals[keyName] = key;
405406
if (selectAsFn) {

test/ng/directive/selectSpec.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1511,11 +1511,12 @@ describe('select', function() {
15111511

15121512
expect(element.val()).toEqual(['1']);
15131513

1514-
element.val(['0']);
1514+
element.children(0).attr('selected', 'selected');
1515+
element.children(1).attr('selected', 'selected');
15151516
browserTrigger(element, 'change');
15161517
scope.$digest();
15171518

1518-
expect(scope.selected).toEqual([10]);
1519+
expect(scope.selected).toEqual([10, 20]);
15191520
});
15201521
});
15211522

0 commit comments

Comments
 (0)