fixup! feat($compile): add support for arbitrary property and event bindings

Author: jbedard

src/ng/compile.js

@@ -3479,7 +3479,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
 
       var sanitizer = identity;
       // Sanitize img[srcset] + source[srcset] values.
-      if ((nodeName === 'img' || nodeName === 'source') && propName === 'srcset') {
+      if (propName === 'srcset' && (nodeName === 'img' || nodeName === 'source')) {
         sanitizer = sanitizeSrcsetPropertyValue;
       } else if (trustedContext) {
         sanitizer = $sce.getTrusted.bind($sce, trustedContext);
@@ -3526,7 +3526,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
       if (EVENT_HANDLER_ATTR_REGEXP.test(name)) {
         throw $compileMinErr('nodomevents',
             'Interpolations for HTML DOM event attributes are disallowed.  Please use the ' +
-                'ng- versions (such as ng-click or ng-on-click instead of onclick) instead.');
+                'ng- versions (such as ng-click or ng-on-click rather than onclick) instead.');
       }
 
       directives.push({

test/ng/compileSpec.js

@@ -12285,15 +12285,15 @@ describe('$compile', function() {
       expect(element.prop('test6')).toBe('Misko');
     }));
 
-    it('should work indipendently of attributes with the same name', inject(function($rootScope, $compile) {
+    it('should work independently of attributes with the same name', inject(function($rootScope, $compile) {
       element = $compile('<span ng-prop-asdf="asdf" asdf="foo" />')($rootScope);
       $rootScope.asdf = 123;
       $rootScope.$digest();
       expect(element.prop('asdf')).toBe(123);
       expect(element.attr('asdf')).toBe('foo');
     }));
 
-    it('should work indipendently of (ng-)attributes with the same name', inject(function($rootScope, $compile) {
+    it('should work independently of (ng-)attributes with the same name', inject(function($rootScope, $compile) {
       element = $compile('<span ng-prop-asdf="asdf" ng-attr-asdf="foo" />')($rootScope);
       $rootScope.asdf = 123;
       $rootScope.$digest();
@@ -12349,7 +12349,7 @@ describe('$compile', function() {
       });
     });
 
-    it('should disallow property binding on onclick', inject(function($compile, $rootScope) {
+    it('should disallow property binding to onclick', inject(function($compile, $rootScope) {
       // All event prop bindings are disallowed.
       $rootScope.onClickJs = function() {};
       expect(function() {
@@ -12364,7 +12364,7 @@ describe('$compile', function() {
           'Please use the ng- versions (such as ng-click or ng-on-click instead of ng-prop-onclick) instead.');
     }));
 
-    it('should process property binding in pre-linking phase at priority 100', function() {
+    it('should process property bindings at $watch time', function() {
       module(function() {
         directive('propLog', function(log) {
           return {