Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 3130a82

Browse files
chore(version-info): remove console.logs and fix code style
1 parent 6a38dbf commit 3130a82

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

lib/versions/version-info.js

+12-16
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ var currentPackage, previousVersions, cdnVersion, gitRepoInfo;
1616
var getPackage = function() {
1717
// Search up the folder hierarchy for the first package.json
1818
var packageFolder = path.resolve('.');
19-
while ( !fs.existsSync(path.join(packageFolder, 'package.json')) ) {
19+
while (!fs.existsSync(path.join(packageFolder, 'package.json'))) {
2020
var parent = path.dirname(packageFolder);
21-
if ( parent === packageFolder) { break; }
21+
if (parent === packageFolder) { break; }
2222
packageFolder = parent;
2323
}
2424
return JSON.parse(fs.readFileSync(path.join(packageFolder,'package.json'), 'UTF-8'));
@@ -48,11 +48,11 @@ var getGitRepoInfo = function() {
4848
* @return {String} The codename if found, otherwise null/undefined
4949
*/
5050
var getCodeName = function(tagName) {
51-
var gitCatOutput = shell.exec('git cat-file -p '+ tagName, {silent:true}).output;
51+
var gitCatOutput = shell.exec('git cat-file -p ' + tagName, {silent:true}).output;
5252
var tagMessage = gitCatOutput.match(/^.*codename.*$/mg)[0];
5353
var codeName = tagMessage && tagMessage.match(/codename\((.*)\)/)[1];
5454
if (!codeName) {
55-
throw new Error("Could not extract release code name. The message of tag "+tagName+
55+
throw new Error("Could not extract release code name. The message of tag " + tagName +
5656
" must match '*codename(some release name)*'");
5757
}
5858
return codeName;
@@ -65,7 +65,7 @@ var getCodeName = function(tagName) {
6565
*/
6666
function getBuild() {
6767
var hash = shell.exec('git rev-parse --short HEAD', {silent: true}).output.replace('\n', '');
68-
return 'sha.'+hash;
68+
return 'sha.' + hash;
6969
}
7070

7171

@@ -76,11 +76,11 @@ function getBuild() {
7676
var getTaggedVersion = function() {
7777
var gitTagResult = shell.exec('git describe --exact-match', {silent:true});
7878

79-
if ( gitTagResult.code === 0 ) {
79+
if (gitTagResult.code === 0) {
8080
var tag = gitTagResult.output.trim();
8181
var version = semver.parse(tag);
8282

83-
if ( version && semver.satisfies(version, currentPackage.branchVersion)) {
83+
if (version && semver.satisfies(version, currentPackage.branchVersion)) {
8484
version.codeName = getCodeName(tag);
8585
version.full = version.version;
8686
version.branch = 'v' + currentPackage.branchPattern.replace('*', 'x');
@@ -102,7 +102,7 @@ var getPreviousVersions = function() {
102102
var repo_url = currentPackage.repository.url;
103103
var tagResults = shell.exec('git ls-remote --tags ' + repo_url,
104104
{silent: true});
105-
if ( tagResults.code === 0 ) {
105+
if (tagResults.code === 0) {
106106
return _(tagResults.output.match(/v[0-9].*[0-9]$/mg))
107107
.map(function(tag) {
108108
var version = semver.parse(tag);
@@ -112,7 +112,7 @@ var getPreviousVersions = function() {
112112
.map(function(version) {
113113
version.docsUrl = 'http://code.angularjs.org/' + version.version + '/docs';
114114
// Versions before 1.0.2 had a different docs folder name
115-
if ( version.major < 1 || (version.major === 1 && version.minor === 0 && version.dot < 2 ) ) {
115+
if (version.major < 1 || (version.major === 1 && version.minor === 0 && version.dot < 2)) {
116116
version.docsUrl += '-' + version.version;
117117
}
118118
return version;
@@ -130,18 +130,14 @@ var getCdnVersion = function() {
130130
return semver.satisfies(tag, currentPackage.branchVersion);
131131
})
132132
.reverse()
133-
.tap(function(versions) {
134-
console.log(versions);
135-
})
136133
.reduce(function(cdnVersion, version) {
137134
if (!cdnVersion) {
138135
// Note: need to use shell.exec and curl here
139136
// as version-infos returns its result synchronously...
140-
var cdnResult = shell.exec('curl http://ajax.googleapis.com/ajax/libs/angularjs/'+version+'/angular.min.js '+
137+
var cdnResult = shell.exec('curl http://ajax.googleapis.com/ajax/libs/angularjs/' + version + '/angular.min.js ' +
141138
'--head --write-out "%{http_code}" -o /dev/null -silent',
142139
{silent: false});
143-
console.log('http://ajax.googleapis.com/ajax/libs/angularjs/'+version+'/angular.min.js');
144-
if ( cdnResult.code === 0 ) {
140+
if (cdnResult.code === 0) {
145141
var statusCode = cdnResult.output.trim();
146142
if (statusCode === '200') {
147143
cdnVersion = version;
@@ -163,7 +159,7 @@ var getSnapshotVersion = function() {
163159
})
164160
.last();
165161

166-
if ( !version ) {
162+
if (!version) {
167163
// a snapshot version before the first tag on the branch
168164
version = semver(currentPackage.branchPattern.replace('*','0-beta.1'));
169165
}

0 commit comments

Comments
 (0)