Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 26ffa81

Browse files
committed
fix(core): remove angular.lower/uppercase
1 parent edd23f1 commit 26ffa81

File tree

7 files changed

+21
-19
lines changed

7 files changed

+21
-19
lines changed

src/AngularPublic.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ function publishExternalAPI(angular) {
156156
'$$csp': csp,
157157
'$$encodeUriSegment': encodeUriSegment,
158158
'$$encodeUriQuery': encodeUriQuery,
159-
'$$stringify': stringify
159+
'$$lowercase': lowercase,
160+
'$$stringify': stringify,
161+
'$$uppercase': uppercase
160162
});
161163

162164
angularModule = setupModuleLoader(window);

src/ngMock/angular-mocks.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2050,13 +2050,13 @@ function MockXhr() {
20502050
var header = this.$$respHeaders[name];
20512051
if (header) return header;
20522052

2053-
name = angular.lowercase(name);
2053+
name = angular.$$lowercase(name);
20542054
header = this.$$respHeaders[name];
20552055
if (header) return header;
20562056

20572057
header = undefined;
20582058
angular.forEach(this.$$respHeaders, function(headerVal, headerName) {
2059-
if (!header && angular.lowercase(headerName) === name) header = headerVal;
2059+
if (!header && angular.$$lowercase(headerName) === name) header = headerVal;
20602060
});
20612061
return header;
20622062
};

src/ngSanitize/sanitize.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ function $SanitizeProvider() {
212212
extend = angular.extend;
213213
forEach = angular.forEach;
214214
isDefined = angular.isDefined;
215-
lowercase = angular.lowercase;
215+
lowercase = angular.$$lowercase;
216216
noop = angular.noop;
217217

218218
htmlParser = htmlParserImpl;

src/ngTouch/touch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var ngTouch = angular.module('ngTouch', []);
2727
ngTouch.provider('$touch', $TouchProvider);
2828

2929
function nodeName_(element) {
30-
return angular.lowercase(element.nodeName || (element[0] && element[0].nodeName));
30+
return angular.$$lowercase(element.nodeName || (element[0] && element[0].nodeName));
3131
}
3232

3333
/**

test/ng/compileSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11186,7 +11186,7 @@ describe('$compile', function() {
1118611186
element = $compile('<iframe srcdoc="{{html}}"></iframe>')($rootScope);
1118711187
$rootScope.html = $sce.trustAsHtml('<div onclick="">hello</div>');
1118811188
$rootScope.$digest();
11189-
expect(angular.lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');
11189+
expect(lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');
1119011190
}));
1119111191
});
1119211192
}

test/ng/directive/ngBindSpec.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -176,17 +176,17 @@ describe('ngBind*', function() {
176176
element = $compile('<div ng-bind-html="html"></div>')($rootScope);
177177
$rootScope.html = '<div onclick="">hello</div>';
178178
$rootScope.$digest();
179-
expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
179+
expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
180180
}));
181181

182182
it('should update html', inject(function($rootScope, $compile, $sce) {
183183
element = $compile('<div ng-bind-html="html"></div>')($rootScope);
184184
$rootScope.html = 'hello';
185185
$rootScope.$digest();
186-
expect(angular.lowercase(element.html())).toEqual('hello');
186+
expect(lowercase(element.html())).toEqual('hello');
187187
$rootScope.html = 'goodbye';
188188
$rootScope.$digest();
189-
expect(angular.lowercase(element.html())).toEqual('goodbye');
189+
expect(lowercase(element.html())).toEqual('goodbye');
190190
}));
191191

192192
it('should one-time bind if the expression starts with two colons', inject(function($rootScope, $compile) {
@@ -220,17 +220,17 @@ describe('ngBind*', function() {
220220
element = $compile('<div ng-bind-html="html"></div>')($rootScope);
221221
$rootScope.html = $sce.trustAsHtml('<div onclick="">hello</div>');
222222
$rootScope.$digest();
223-
expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
223+
expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
224224
}));
225225

226226
it('should update html', inject(function($rootScope, $compile, $sce) {
227227
element = $compile('<div ng-bind-html="html"></div>')($rootScope);
228228
$rootScope.html = $sce.trustAsHtml('hello');
229229
$rootScope.$digest();
230-
expect(angular.lowercase(element.html())).toEqual('hello');
230+
expect(lowercase(element.html())).toEqual('hello');
231231
$rootScope.html = $sce.trustAsHtml('goodbye');
232232
$rootScope.$digest();
233-
expect(angular.lowercase(element.html())).toEqual('goodbye');
233+
expect(lowercase(element.html())).toEqual('goodbye');
234234
}));
235235

236236
it('should not cause infinite recursion for trustAsHtml object watches',
@@ -243,7 +243,7 @@ describe('ngBind*', function() {
243243
return $sce.trustAsHtml('<div onclick="">hello</div>');
244244
};
245245
$rootScope.$digest();
246-
expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
246+
expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
247247
}));
248248

249249
it('should handle custom $sce objects', function() {
@@ -266,10 +266,10 @@ describe('ngBind*', function() {
266266
var html = 'hello';
267267
$rootScope.getHtml = function() { return $sce.trustAsHtml(html); };
268268
$rootScope.$digest();
269-
expect(angular.lowercase(element.html())).toEqual('hello');
269+
expect(lowercase(element.html())).toEqual('hello');
270270
html = 'goodbye';
271271
$rootScope.$digest();
272-
expect(angular.lowercase(element.html())).toEqual('goodbye');
272+
expect(lowercase(element.html())).toEqual('goodbye');
273273
});
274274
});
275275

@@ -280,7 +280,7 @@ describe('ngBind*', function() {
280280
element = $compile('<div ng-bind-html="html"></div>')($rootScope);
281281
$rootScope.html = '<div onclick="">hello</div>';
282282
$rootScope.$digest();
283-
expect(angular.lowercase(element.html())).toEqual('<div>hello</div>');
283+
expect(lowercase(element.html())).toEqual('<div>hello</div>');
284284
}));
285285
});
286286
});

test/ngSanitize/directive/ngBindHtmlSpec.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('ngBindHtml', function() {
88
var element = $compile('<div ng-bind-html="html"></div>')($rootScope);
99
$rootScope.html = '<div unknown>hello</div>';
1010
$rootScope.$digest();
11-
expect(angular.lowercase(element.html())).toEqual('<div>hello</div>');
11+
expect(lowercase(element.html())).toEqual('<div>hello</div>');
1212
}));
1313

1414

@@ -18,11 +18,11 @@ describe('ngBindHtml', function() {
1818
angular.forEach([null, undefined, ''], function(val) {
1919
$rootScope.html = 'some val';
2020
$rootScope.$digest();
21-
expect(angular.lowercase(element.html())).toEqual('some val');
21+
expect(lowercase(element.html())).toEqual('some val');
2222

2323
$rootScope.html = val;
2424
$rootScope.$digest();
25-
expect(angular.lowercase(element.html())).toEqual('');
25+
expect(lowercase(element.html())).toEqual('');
2626
});
2727
}));
2828
});

0 commit comments

Comments
 (0)