This repository was archived by the owner on Apr 12, 2024. It is now read-only.
File tree 1 file changed +7
-8
lines changed
1 file changed +7
-8
lines changed Original file line number Diff line number Diff line change @@ -232,21 +232,20 @@ To create and submit a change:
232
232
233
233
3. Create your patch, make sure to have plenty of tests (that pass).
234
234
235
- 4. Commit your changes:
235
+ 4. Commit your changes and create a descriptive commit message (the commit message is used to generate release notes,
236
+ please check out our
237
+ [commit message conventions](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#)
238
+ and our commit message presubmit hook `validate-commit-msg.js`):
236
239
237
240
git commit -a
238
241
239
- 5. Run JavaScript Lint and be sure to address all new warnings and errors:
240
-
241
- rake lint
242
-
243
- 6. Push your branch to Github:
242
+ 5. Push your branch to Github:
244
243
245
244
git push origin my-fix-branch
246
245
247
- 7 . In Github, send a pull request to `angular:master`.
246
+ 6 . In Github, send a pull request to `angular:master`.
248
247
249
- 8 . When the patch is reviewed and merged, delete your branch and pull yours — and other — changes
248
+ 7 . When the patch is reviewed and merged, delete your branch and pull yours — and other — changes
250
249
from the main (upstream) repository:
251
250
252
251
1. To delete the branch in Github, run:
You can’t perform that action at this time.
0 commit comments