refactor(*): remove add/removeEventListenerFn wrappers

- in some tests these methods are 2x as expensive as the actual add/removeEventListener which they wrap
- in the largetable ngmodel this removes ~1%

Author: jbedard

src/.jshintrc

@@ -140,8 +140,6 @@
     "getAliasedAttrName": false,
     "createEventHandler": false,
     "JQLitePrototype": false,
-    "addEventListenerFn": false,
-    "removeEventListenerFn": false,
     "jqLiteIsTextNode": false,
     "jqLiteDocumentLoaded": false,
 

src/jqLite.js

@@ -1,8 +1,6 @@
 'use strict';
 
 /* global JQLitePrototype: true,
-  addEventListenerFn: true,
-  removeEventListenerFn: true,
   BOOLEAN_ATTR: true,
   ALIASED_ATTR: true,
 */
@@ -103,13 +101,7 @@
 JQLite.expando = 'ng339';
 
 var jqCache = JQLite.cache = {},
-    jqId = 1,
-    addEventListenerFn = function(element, type, fn) {
-      element.addEventListener(type, fn, false);
-    },
-    removeEventListenerFn = function(element, type, fn) {
-      element.removeEventListener(type, fn, false);
-    };
+    jqId = 1;
 
 /*
  * !!! This is an undocumented "private" function !!!
@@ -276,7 +268,7 @@ function jqLiteOff(element, type, fn, unsupported) {
   if (!type) {
     for (type in events) {
       if (type !== '$destroy') {
-        removeEventListenerFn(element, type, handle);
+        element.removeEventListener(type, handle, false);
       }
       delete events[type];
     }
@@ -290,7 +282,7 @@ function jqLiteOff(element, type, fn, unsupported) {
         }
       }
 
-      removeEventListenerFn(element, type, handle);
+      element.removeEventListener(type, handle, false);
       delete events[type];
     });
   }
@@ -811,7 +803,7 @@ forEach({
 
         } else {
           if (type !== '$destroy') {
-            addEventListenerFn(element, type, handle);
+            element.addEventListener(type, handle, false);
           }
         }
         eventFns = events[type];

src/ng/directive/form.js

@@ -474,13 +474,13 @@ var formDirectiveFactory = function(isNgForm) {
                 event.preventDefault();
               };
 
-              addEventListenerFn(formElement[0], 'submit', handleFormSubmission);
+              formElement[0].addEventListener('submit', handleFormSubmission, false);
 
               // unregister the preventDefault listener so that we don't not leak memory but in a
               // way that will achieve the prevention of the default action.
               formElement.on('$destroy', function() {
                 $timeout(function() {
-                  removeEventListenerFn(formElement[0], 'submit', handleFormSubmission);
+                  formElement[0].removeEventListener('submit', handleFormSubmission, false);
                 }, 0, false);
               });
             }

src/ng/httpBackend.js

@@ -146,8 +146,8 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
     script.async = true;
 
     callback = function(event) {
-      removeEventListenerFn(script, "load", callback);
-      removeEventListenerFn(script, "error", callback);
+      script.removeEventListener("load", callback, false);
+      script.removeEventListener("error", callback, false);
       rawDocument.body.removeChild(script);
       script = null;
       var status = -1;
@@ -166,8 +166,8 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
       }
     };
 
-    addEventListenerFn(script, "load", callback);
-    addEventListenerFn(script, "error", callback);
+    script.addEventListener("load", callback, false);
+    script.addEventListener("error", callback, false);
     rawDocument.body.appendChild(script);
     return callback;
   }

test/.jshintrc

@@ -116,8 +116,6 @@
     "getBooleanAttrName": false,
     "createEventHandler": false,
     "JQLitePrototype": false,
-    "addEventListenerFn": false,
-    "removeEventListenerFn": false,
     "jqLiteDocumentLoaded": false,
 
     /* apis.js */

test/ng/directive/formSpec.js

@@ -283,7 +283,7 @@ describe('form', function() {
         submitted = true;
       };
 
-      addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener);
+      doc[0].addEventListener('submit', assertPreventDefaultListener, false);
 
       browserTrigger(doc.find('input'));
 
@@ -297,7 +297,7 @@ describe('form', function() {
         expect(submitted).toBe(true);
 
         // prevent mem leak in test
-        removeEventListenerFn(doc[0], 'submit', assertPreventDefaultListener);
+        doc[0].removeEventListener('submit', assertPreventDefaultListener, false);
       });
     });
 
@@ -334,7 +334,7 @@ describe('form', function() {
 
       $compile(doc)(scope);
 
-      addEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
+      form[0].addEventListener('submit', assertPreventDefaultListener, false);
 
       browserTrigger(doc.find('button'), 'click');
 
@@ -353,7 +353,7 @@ describe('form', function() {
                                        // now. (i)
 
         // prevent mem leak in test
-        removeEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
+        form[0].removeEventListener('submit', assertPreventDefaultListener, false);
       });
     }));