perf($rootScope): do not mark $watchCollectionInterceptor as $stateful

Author: jbedard

src/ng/parse.js

@@ -1944,6 +1944,7 @@ function $ParseProvider() {
         return second(first(value));
       }
       chainedInterceptor.$stateful = first.$stateful || second.$stateful;
+      chainedInterceptor.$pure = first.$pure && second.$pure;
 
       return chainedInterceptor;
     }
@@ -1979,14 +1980,18 @@ function $ParseProvider() {
       // If the expression itself has no inputs then use the full expression as an input.
       if (!interceptorFn.$stateful) {
         useInputs = !parsedExpression.inputs;
-        fn.inputs = (parsedExpression.inputs ? parsedExpression.inputs : [parsedExpression]).map(function(e) {
+        fn.inputs = parsedExpression.inputs ? parsedExpression.inputs : [parsedExpression];
+
+        if (!interceptorFn.$pure) {
+          fn.inputs = fn.inputs.map(function(e) {
               // Remove the isPure flag of inputs when it is not absolute because they are now wrapped in a
-              // potentially non-pure interceptor function.
+              // non-pure interceptor function.
               if (e.isPure === PURITY_RELATIVE) {
                 return function depurifier(s) { return e(s); };
               }
               return e;
             });
+        }
       }
 
       return addWatchDelegate(fn);

src/ng/rootScope.js

@@ -581,7 +581,10 @@ function $RootScopeProvider() {
        *    de-registration function is executed, the internal watch operation is terminated.
        */
       $watchCollection: function(obj, listener) {
-        $watchCollectionInterceptor.$stateful = true;
+        // If the expression is a literal then the interceptor is completely pure - it only results
+        // in a new object if one of its inputs (the collection values) changes.
+        // Otherwise mark it as $stateful to avoid any input-watching and always invoke the interceptor
+        $watchCollectionInterceptor.$stateful = !($watchCollectionInterceptor.$pure = $parse(obj).literal);
 
         var self = this;
         // the current value, updated on each dirty-check run