From f9f86bf23f3f8ce4f65dde563214226b20886b5a Mon Sep 17 00:00:00 2001 From: Ward Bell Date: Sat, 29 Oct 2016 23:36:24 -0700 Subject: [PATCH] docs(testing): revert to jasmine v.2.4.1 Bug in Jasmine v.2.5.x. Stick with v.2.4.1 (as karma-jasmine does) until the following issue is resolved: https://github.com/jasmine/jasmine/issues/1231 Unfortunately, there is no `@types/jasmine` for v.2.4 but only for v.2.5. --- public/docs/_examples/package.json | 6 +++--- tools/plunker-builder/indexHtmlTranslator.js | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/public/docs/_examples/package.json b/public/docs/_examples/package.json index 59d840ae67..a46ac1b718 100644 --- a/public/docs/_examples/package.json +++ b/public/docs/_examples/package.json @@ -46,7 +46,7 @@ "@types/angular-route": "^1.3.2", "@types/angular-sanitize": "^1.3.3", "@types/core-js": "^0.9.34", - "@types/jasmine": "^2.5.35", + "@types/jasmine": "~2.5.36", "@types/node": "^6.0.45", "@types/selenium-webdriver": "^2.53.32", "angular2-template-loader": "^0.4.0", @@ -59,8 +59,8 @@ "html-loader": "^0.4.3", "html-webpack-plugin": "^2.16.1", "http-server": "^0.9.0", - "jasmine": "^2.5.2", - "jasmine-core": "^2.5.2", + "jasmine": "~2.4.1", + "jasmine-core": "~2.4.1", "karma": "^1.3.0", "karma-chrome-launcher": "^2.0.0", "karma-cli": "^1.0.1", diff --git a/tools/plunker-builder/indexHtmlTranslator.js b/tools/plunker-builder/indexHtmlTranslator.js index 6f97f1d401..85a3c8d99e 100644 --- a/tools/plunker-builder/indexHtmlTranslator.js +++ b/tools/plunker-builder/indexHtmlTranslator.js @@ -71,6 +71,8 @@ var _rxData = [ // Test libraries // Plunker recommends getting jasmine from cloudfare + // Don't upgrade to 2.5.x until following issue resolved + // https://github.com/jasmine/jasmine/issues/1231 { pattern: 'script', from: 'node_modules/jasmine-core/lib/jasmine-core/jasmine.js',