Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit e9d7813

Browse files
authored
docs(testing): revert to jasmine v.2.4.1 (#2697)
Bug in Jasmine v.2.5.x. Stick with v.2.4.1 (as karma-jasmine does) until the following issue is resolved: jasmine/jasmine#1231 Unfortunately, there is no `@types/jasmine` for v.2.4 but only for v.2.5.
1 parent 7e5f5a2 commit e9d7813

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

public/docs/_examples/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@types/angular-route": "^1.3.2",
4747
"@types/angular-sanitize": "^1.3.3",
4848
"@types/core-js": "^0.9.34",
49-
"@types/jasmine": "^2.5.35",
49+
"@types/jasmine": "~2.5.36",
5050
"@types/node": "^6.0.45",
5151
"@types/selenium-webdriver": "^2.53.32",
5252
"angular2-template-loader": "^0.4.0",
@@ -59,8 +59,8 @@
5959
"html-loader": "^0.4.3",
6060
"html-webpack-plugin": "^2.16.1",
6161
"http-server": "^0.9.0",
62-
"jasmine": "^2.5.2",
63-
"jasmine-core": "^2.5.2",
62+
"jasmine": "~2.4.1",
63+
"jasmine-core": "~2.4.1",
6464
"karma": "^1.3.0",
6565
"karma-chrome-launcher": "^2.0.0",
6666
"karma-cli": "^1.0.1",

tools/plunker-builder/indexHtmlTranslator.js

+2
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ var _rxData = [
7171
// Test libraries
7272

7373
// Plunker recommends getting jasmine from cloudfare
74+
// Don't upgrade to 2.5.x until following issue resolved
75+
// https://github.com/jasmine/jasmine/issues/1231
7476
{
7577
pattern: 'script',
7678
from: 'node_modules/jasmine-core/lib/jasmine-core/jasmine.js',

0 commit comments

Comments
 (0)