incorporate cnishina's review

Author: filipesilva

public/docs/_examples/cb-dynamic-form-deprecated/e2e-spec.ts.disabled

@@ -1,7 +1,6 @@
 'use strict'; // necessary for es6 output in node 
 
 import { browser, element, by } from 'protractor/globals';
-import { sendKeys } from '../protractor-helpers';
 
 /* tslint:disable:quotemark */
 describe('Dynamic Form Deprecated', function () {

public/docs/_examples/debug.log

@@ -149,13 +149,12 @@ describe('Dependency Injection Tests', function () {
       let heroes = element.all(by.css('#unauthorized hero-list div'));
       expect(heroes.count()).toBeGreaterThan(0);
 
-      let filteredHeroes = heroes.filter(function(elem: ElementFinder, index: number){
-        return elem.getText().then(function(text: string) {
+      let filteredHeroes = heroes.filter((elem: ElementFinder, index: number) => {
+        return elem.getText().then((text: string) => {
           return /secret/.test(text);
         });
       });
 
-      // console.log("******Secret heroes count: "+filteredHeroes.length);
       expect(filteredHeroes.count()).toEqual(0);
     });
 
@@ -190,7 +189,6 @@ describe('Dependency Injection Tests', function () {
           });
         });
 
-        // console.log("******Secret heroes count: "+filteredHeroes.length);
         expect(filteredHeroes.count()).toBeGreaterThan(0);
       });
 

public/docs/_examples/dependency-injection/e2e-spec.ts

@@ -1,9 +1,9 @@
 'use strict'; // necessary for es6 output in node 
 
 import { browser, element, by } from 'protractor/globals';
-import { sendKeys } from '../protractor-helpers';
+import { appLang, describeIf } from '../protractor-helpers';
 
-describeIf(browser.appIsTs || browser.appIsJs, 'Forms (Deprecated) Tests', function () {
+describeIf(appLang.appIsTs || appLang.appIsJs, 'Forms (Deprecated) Tests', function () {
 
   beforeEach(function () {
     browser.get('');
@@ -49,8 +49,7 @@ describeIf(browser.appIsTs || browser.appIsJs, 'Forms (Deprecated) Tests', funct
     let newValue: string;
     let alterEgoEle = element.all(by.css('input[ngcontrol=alterEgo]')).get(0);
     alterEgoEle.getAttribute('value').then(function(value) {
-      // alterEgoEle.sendKeys(test);
-      sendKeys(alterEgoEle, test);
+      alterEgoEle.sendKeys(test);
       newValue = value + test;
       expect(alterEgoEle.getAttribute('value')).toEqual(newValue);
     }).then(function() {

public/docs/_examples/forms-deprecated/e2e-spec.ts.disabled

@@ -50,7 +50,6 @@ describeIf(appLang.appIsTs || appLang.appIsJs, 'Forms Tests', function () {
       alterEgoEle.sendKeys(test);
       newValue = value + test;
       expect(alterEgoEle.getAttribute('value')).toEqual(newValue);
-    }).then(function() {
       let b = element.all(by.css('button[type=submit]')).get(0);
       return b.click();
     }).then(function() {

public/docs/_examples/forms/e2e-spec.ts

@@ -1,7 +1,6 @@
 'use strict'; // necessary for es6 output in node 
 
 import { browser, element, by } from 'protractor/globals';
-import { sendKeys } from '../protractor-helpers';
 
 describe('Router', function () {
 
@@ -85,7 +84,7 @@ describe('Router', function () {
       expect(page.heroDetail.isPresent()).toBe(true, 'should be able to see crisis detail');
       expect(page.heroDetailTitle.getText()).toContain(heroText);
       let inputEle = page.heroDetail.element(by.css('input'));
-      return sendKeys(inputEle, '-foo');
+      inputEle.sendKeys('-foo');
     }).then(function() {
       expect(page.heroDetailTitle.getText()).toContain(heroText + '-foo');
       let buttonEle = page.heroDetail.element(by.css('button'));
@@ -113,7 +112,7 @@ describe('Router', function () {
       expect(page.crisisDetail.isPresent()).toBe(true, 'should be able to see crisis detail');
       expect(page.crisisDetailTitle.getText()).toContain(crisisText);
       let inputEle = page.crisisDetail.element(by.css('input'));
-      return sendKeys(inputEle, '-foo');
+      inputEle.sendKeys('-foo');
     }).then(function () {
       expect(page.crisisDetailTitle.getText()).toContain(crisisText + '-foo');
       let buttonEle = page.crisisDetail.element(by.cssContainingText('button', shouldSave ? 'Save' : 'Cancel'));

public/docs/_examples/router-deprecated/e2e-spec.ts.disabled

@@ -116,7 +116,7 @@ function updateHeroTests() {
 
 function addToHeroName(text: string): WPromise<void> {
   let input = element(by.css('input'));
-  input.sendKeys(text);
+  return input.sendKeys(text);
 }
 
 function expectHeading(hLevel: number, expectedText: string): void {

public/docs/_examples/toh-3/e2e-spec.ts

@@ -116,7 +116,7 @@ function updateHeroTests() {
 
 function addToHeroName(text: string): WPromise<void> {
   let input = element(by.css('input'));
-  input.sendKeys(text);
+  return input.sendKeys(text);
 }
 
 function expectHeading(hLevel: number, expectedText: string): void {

public/docs/_examples/toh-4/e2e-spec.ts

@@ -176,7 +176,7 @@ describe('Tutorial part 5', () => {
 
 function addToHeroName(text: string): WPromise<void> {
   let input = element(by.css('input'));
-  input.sendKeys(text);
+  return input.sendKeys(text);
 }
 
 function expectHeading(hLevel: number, expectedText: string): void {

public/docs/_examples/toh-5/e2e-spec.ts

@@ -263,7 +263,7 @@ describe('Tutorial part 6', () => {
 
 function addToHeroName(text: string): WPromise<void> {
   let input = element(by.css('input'));
-  input.sendKeys(text);
+  return input.sendKeys(text);
 }
 
 function expectHeading(hLevel: number, expectedText: string): void {

public/docs/_examples/toh-6/e2e-spec.ts

@@ -1,7 +1,6 @@
 'use strict'; // necessary for es6 output in node 
 
 import { browser, element, by } from 'protractor/globals';
-import { sendKeys } from '../protractor-helpers';
 
 // Angular E2E Testing Guide:
 // https://docs.angularjs.org/guide/e2e-testing
@@ -30,11 +29,11 @@ describe('PhoneCat Application', function() {
 
       expect(phoneList.count()).toBe(20);
 
-      sendKeys(query, 'nexus');
+      query.sendKeys('nexus');
       expect(phoneList.count()).toBe(1);
 
       query.clear();
-      sendKeys(query, 'motorola');
+      query.sendKeys('motorola');
       expect(phoneList.count()).toBe(8);
     });
 
@@ -50,7 +49,7 @@ describe('PhoneCat Application', function() {
         });
       }
 
-      sendKeys(queryField, 'tablet');   // Let's narrow the dataset to make the assertions shorter
+      queryField.sendKeys('tablet');   // Let's narrow the dataset to make the assertions shorter
 
       expect(getNames()).toEqual([
         'Motorola XOOM\u2122 with Wi-Fi',