Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 806c658

Browse files
chalinfilipesilva
authored andcommitted
docs(forms): copyedits (#3149)
* - Copyedits, some from Kathy (from an early revision of the forms page). - Removed side note detailing ngModel; now referring reader to template-syntax page instead. * post-review edits
1 parent b793d1d commit 806c658

File tree

3 files changed

+246
-259
lines changed

3 files changed

+246
-259
lines changed

public/docs/_examples/forms/ts/app/hero-form.component.html

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
1-
<!-- #docplaster -->
2-
<!-- #docregion final -->
1+
<!-- #docplaster -->
2+
<!-- #docregion final -->
33
<div class="container">
44
<!-- #docregion edit-div -->
5-
<div [hidden]="submitted">
5+
<div [hidden]="submitted">
66
<h1>Hero Form</h1>
77
<!-- #docregion ngSubmit -->
88
<form (ngSubmit)="onSubmit()" #heroForm="ngForm">
9-
<!-- #enddocregion ngSubmit -->
10-
<!-- #enddocregion edit-div -->
9+
<!-- #enddocregion ngSubmit, edit-div -->
1110
<div class="form-group">
1211
<!-- #docregion name-with-error-msg -->
1312
<label for="name">Name</label>
1413
<input type="text" class="form-control" id="name"
1514
required
1615
[(ngModel)]="model.name" name="name"
17-
#name="ngModel" >
16+
#name="ngModel">
1817
<!-- #docregion hidden-error-msg -->
1918
<div [hidden]="name.valid || name.pristine"
2019
class="alert alert-danger">
@@ -27,15 +26,15 @@ <h1>Hero Form</h1>
2726
<div class="form-group">
2827
<label for="alterEgo">Alter Ego</label>
2928
<input type="text" class="form-control" id="alterEgo"
30-
[(ngModel)]="model.alterEgo" name="alterEgo" >
29+
[(ngModel)]="model.alterEgo" name="alterEgo">
3130
</div>
3231

3332
<div class="form-group">
3433
<label for="power">Hero Power</label>
3534
<select class="form-control" id="power"
3635
required
3736
[(ngModel)]="model.power" name="power"
38-
#power="ngModel" >
37+
#power="ngModel">
3938
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
4039
</select>
4140
<div [hidden]="power.valid || power.pristine" class="alert alert-danger">
@@ -185,25 +184,25 @@ <h1>Hero Form</h1>
185184
<!-- EXTRA MATERIAL FOR DOCUMENTATION -->
186185
<hr>
187186
<!-- #docregion ngModelName-1 -->
188-
<input type="text" class="form-control" id="name"
187+
<input type="text" class="form-control" id="name"
189188
required
190189
[(ngModel)]="model.name" name="name">
191-
TODO: remove this: {{model.name}}
190+
TODO: remove this: {{model.name}}
192191
<!-- #enddocregion ngModelName-1 -->
193192
<hr>
194193
<!-- #docregion ngModel-3-->
195194
<input type="text" class="form-control" id="name"
196195
required
197196
[ngModel]="model.name" name="name"
198-
(ngModelChange)="model.name = $event" >
199-
TODO: remove this: {{model.name}}
197+
(ngModelChange)="model.name = $event">
198+
TODO: remove this: {{model.name}}
200199
<!-- #enddocregion ngModel-3-->
201200
<hr>
202201
<!-- #docregion ngModelName-2 -->
203202
<input type="text" class="form-control" id="name"
204203
required
205204
[(ngModel)]="model.name" name="name"
206-
#spy >
205+
#spy>
207206
<br>TODO: remove this: {{spy.className}}
208207
<!-- #enddocregion ngModelName-2 -->
209208

public/docs/_examples/forms/ts/app/hero-form.component.ts

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// #docplaster
2-
// #docregion
3-
// #docregion first, final
2+
// #docregion , v1, final
43
import { Component } from '@angular/core';
54

65
import { Hero } from './hero';
@@ -26,21 +25,29 @@ export class HeroFormComponent {
2625
// #enddocregion final
2726
// TODO: Remove this when we're done
2827
get diagnostic() { return JSON.stringify(this.model); }
29-
// #enddocregion first
28+
// #enddocregion v1
3029

31-
// #docregion final
32-
// #docregion new-hero
30+
// #docregion final, new-hero
3331
newHero() {
3432
this.model = new Hero(42, '', '');
3533
}
36-
// #enddocregion new-hero
37-
// #enddocregion final
34+
// #enddocregion final, new-hero
35+
36+
skyDog(): Hero {
37+
// #docregion SkyDog
38+
let myHero = new Hero(42, 'SkyDog',
39+
'Fetch any object at any distance',
40+
'Leslie Rollover');
41+
console.log('My hero is called ' + myHero.name); // "My hero is called SkyDog"
42+
// #enddocregion SkyDog
43+
return myHero;
44+
}
45+
3846
//////// NOT SHOWN IN DOCS ////////
3947

4048
// Reveal in html:
4149
// Name via form.controls = {{showFormControls(heroForm)}}
4250
showFormControls(form: any) {
43-
4451
return form && form.controls['name'] &&
4552
// #docregion form-controls
4653
form.controls['name'].value; // Dr. IQ
@@ -49,6 +56,5 @@ export class HeroFormComponent {
4956

5057
/////////////////////////////
5158

52-
// #docregion first, final
59+
// #docregion v1, final
5360
}
54-
// #enddocregion first, final

0 commit comments

Comments
 (0)