Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit e4f7e34

Browse files
vicbtravis@travis-ci.org
authored andcommitted
perf(tagging_view_factory): Move a test out of the loop
1 parent 6fea97d commit e4f7e34

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

lib/core_dom/tagging_view_factory.dart

+8-6
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,15 @@ class TaggingViewFactory implements ViewFactory {
6060

6161
if (node.nodeType == 1) {
6262
var elts = node.querySelectorAll('.ng-binding');
63-
// HACK: querySelectorAll doesn't return the node.
64-
var startIndex = node.classes.contains('ng-binding') ? -1 : 0;
65-
for (int j = startIndex, jj = elts.length; j < jj; j++, elementBinderIndex++) {
63+
// querySelectorAll doesn't return the node itself
64+
if (node.classes.contains('ng-binding')) {
65+
var tagged = elementBinders[elementBinderIndex];
66+
_bindTagged(tagged, elementBinderIndex, rootInjector, elementInjectors, view, node);
67+
elementBinderIndex++;
68+
}
69+
for (int j = 0; j < elts.length; j++, elementBinderIndex++) {
6670
TaggedElementBinder tagged = elementBinders[elementBinderIndex];
67-
var boundNode = j == -1 ? node : elts[j];
68-
69-
_bindTagged(tagged, elementBinderIndex, rootInjector, elementInjectors, view, boundNode);
71+
_bindTagged(tagged, elementBinderIndex, rootInjector, elementInjectors, view, elts[j]);
7072
}
7173
} else if (node.nodeType == 3 || node.nodeType == 8) {
7274
TaggedElementBinder tagged = elementBinders[elementBinderIndex];

0 commit comments

Comments
 (0)