chore: update property chain check for ng-events

Author: welbornio

src/modules/events.js

@@ -48,8 +48,19 @@ function ngEventDirectivesDecorator(ngEventAttrName) {
       return function ngEventHandler(scope, element, attrs) {
         var boundFuncs = getFunctionNames(attrs[ngEventAttrName]);
         boundFuncs.forEach(function(boundFn) {
-          if ($parse(boundFn)(scope) === undefined) {
-            angular.hint.log(MODULE_NAME, boundFn + ' is undefined');
+          var property, propChain, lastProp = '';
+          while((property = boundFn.match(/^.+?([^\.\[])*/)) !== null) {
+            property = property[0];
+            propChain = lastProp + property;
+            if ($parse(propChain)(scope) === undefined) {
+              angular.hint.log(MODULE_NAME, propChain + ' is undefined');
+            }
+            boundFn = boundFn.replace(property, '');
+            lastProp += property;
+            if(boundFn.charAt(0) === '.') {
+              lastProp += '.';
+              boundFn = boundFn.substr(1);
+            }
           }
         });
 

test/events.spec.js

@@ -26,14 +26,28 @@ describe('hintEvents', function() {
   });
 
   // TODO: implement this
-  xit('should log a message if the path to handle an ng-event is not found', function() {
+  it('should log a message if the path to handle an ng-event is not found', function() {
     var elt = angular.element('<button ng-click="a.b.c()">Fake Increment</button>');
     $compile(elt)($rootScope);
     $rootScope.a = {};
 
     $rootScope.$digest();
     elt.triggerHandler('click');
+    // expect(angular.hint.log).not.toHaveBeenCalledWith('Events', 'a is undefined');
     expect(angular.hint.log).toHaveBeenCalledWith('Events', 'a.b is undefined');
+    expect(angular.hint.log).toHaveBeenCalledWith('Events', 'a.b.c is undefined');
+  });
+
+  it('should log a message if the path to handle an ng-event with array syntax is not found', function() {
+    var elt = angular.element('<button ng-click="a[\'b\'].c()">Fake Increment</button>');
+    $compile(elt)($rootScope);
+    $rootScope.a = {};
+
+    $rootScope.$digest();
+    elt.triggerHandler('click');
+    // expect(angular.hint.log).not.toHaveBeenCalledWith('Events', 'a is undefined');
+    expect(angular.hint.log).toHaveBeenCalledWith('Events', 'a[\'b\'] is undefined');
+    expect(angular.hint.log).toHaveBeenCalledWith('Events', 'a[\'b\'].c is undefined');
   });