Skip to content

Commit e692f69

Browse files
author
Angular Builds
committed
93f7a2a Revert "test: update e2e update test to include content in css file"
1 parent 8b23093 commit e692f69

File tree

5 files changed

+26
-28
lines changed

5 files changed

+26
-28
lines changed

package.json

+17-17
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
{
22
"name": "@angular-devkit/build-angular",
3-
"version": "18.0.0-next.0+sha-d05f78b",
3+
"version": "18.0.0-next.0+sha-93f7a2a",
44
"description": "Angular Webpack Build Facade",
55
"main": "src/index.js",
66
"typings": "src/index.d.ts",
77
"builders": "builders.json",
88
"dependencies": {
99
"@ampproject/remapping": "2.3.0",
10-
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#d05f78b",
11-
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#d05f78b",
12-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#d05f78b",
13-
"@babel/core": "7.24.0",
14-
"@babel/generator": "7.23.6",
10+
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#93f7a2a",
11+
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#93f7a2a",
12+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#93f7a2a",
13+
"@babel/core": "7.24.3",
14+
"@babel/generator": "7.24.1",
1515
"@babel/helper-annotate-as-pure": "7.22.5",
1616
"@babel/helper-split-export-declaration": "7.22.6",
17-
"@babel/plugin-transform-async-generator-functions": "7.23.9",
18-
"@babel/plugin-transform-async-to-generator": "7.23.3",
19-
"@babel/plugin-transform-runtime": "7.24.0",
20-
"@babel/preset-env": "7.24.0",
21-
"@babel/runtime": "7.24.0",
17+
"@babel/plugin-transform-async-generator-functions": "7.24.3",
18+
"@babel/plugin-transform-async-to-generator": "7.24.1",
19+
"@babel/plugin-transform-runtime": "7.24.3",
20+
"@babel/preset-env": "7.24.3",
21+
"@babel/runtime": "7.24.1",
2222
"@discoveryjs/json-ext": "0.5.7",
23-
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#d05f78b",
23+
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#93f7a2a",
2424
"@vitejs/plugin-basic-ssl": "1.1.0",
2525
"ansi-colors": "4.1.3",
2626
"autoprefixer": "10.4.18",
@@ -49,7 +49,7 @@
4949
"parse5-html-rewriting-stream": "7.0.0",
5050
"picomatch": "4.0.1",
5151
"piscina": "4.4.0",
52-
"postcss": "8.4.35",
52+
"postcss": "8.4.37",
5353
"postcss-loader": "8.1.1",
5454
"resolve-url-loader": "5.0.0",
5555
"rxjs": "7.8.1",
@@ -62,11 +62,11 @@
6262
"tree-kill": "1.2.2",
6363
"tslib": "2.6.2",
6464
"undici": "6.9.0",
65-
"vite": "5.1.6",
65+
"vite": "5.2.2",
6666
"watchpack": "2.4.1",
67-
"webpack": "5.90.3",
68-
"webpack-dev-middleware": "7.0.0",
69-
"webpack-dev-server": "5.0.3",
67+
"webpack": "5.91.0",
68+
"webpack-dev-middleware": "7.1.1",
69+
"webpack-dev-server": "5.0.4",
7070
"webpack-merge": "5.10.0",
7171
"webpack-subresource-integrity": "5.1.0"
7272
},

src/tools/vite/angular-memory-plugin.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -230,13 +230,11 @@ exports.createAngularMemoryPlugin = createAngularMemoryPlugin;
230230
*/
231231
async function loadViteClientCode(file) {
232232
const originalContents = await (0, promises_1.readFile)(file, 'utf-8');
233-
const firstUpdate = originalContents.replace('You can also disable this overlay by setting', '');
234-
(0, node_assert_1.default)(originalContents !== firstUpdate, 'Failed to update Vite client error overlay text. (1)');
235-
const secondUpdate = firstUpdate.replace(
236-
// eslint-disable-next-line max-len
237-
'<code part="config-option-name">server.hmr.overlay</code> to <code part="config-option-value">false</code> in <code part="config-file-name">${hmrConfigName}.</code>', '');
238-
(0, node_assert_1.default)(firstUpdate !== secondUpdate, 'Failed to update Vite client error overlay text. (2)');
239-
return secondUpdate;
233+
const updatedContents = originalContents.replace(`h('br'), 'You can also disable this overlay by setting ', ` +
234+
`h('code', { part: 'config-option-name' }, 'server.hmr.overlay'), '` +
235+
` to ', h('code', { part: 'config-option-value' }, 'false'), ' in ', h('code', { part: 'config-file-name' }, hmrConfigName), '.'`, '');
236+
(0, node_assert_1.default)(originalContents !== updatedContents, 'Failed to update Vite client error overlay text.');
237+
return updatedContents;
240238
}
241239
function pathnameWithoutBasePath(url, basePath) {
242240
const parsedUrl = new URL(url, 'http://localhost');

src/tools/webpack/plugins/builder-watch-plugin.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class BuilderWatchFileSystem {
5151
const directoryChanges = new Set();
5252
const missingChanges = new Set();
5353
for (const event of events) {
54-
this.inputFileSystem.purge?.(event.path);
54+
this.inputFileSystem?.purge?.(event.path);
5555
if (event.type === 'deleted') {
5656
timeInfo.delete(event.path);
5757
removals.add(event.path);
@@ -70,7 +70,7 @@ class BuilderWatchFileSystem {
7070
}
7171
}
7272
const timeInfoMap = new Map(timeInfo);
73-
callback(undefined, timeInfoMap, timeInfoMap, new Set([...fileChanges, ...directoryChanges, ...missingChanges]), removals);
73+
callback(null, timeInfoMap, timeInfoMap, new Set([...fileChanges, ...directoryChanges, ...missingChanges]), removals);
7474
});
7575
});
7676
return {

src/tools/webpack/plugins/styles-webpack-plugin.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class StylesWebpackPlugin {
3434
preferRelative: true,
3535
useSyncFileSystemCalls: true,
3636
symlinks: !preserveSymlinks,
37-
fileSystem: compiler.inputFileSystem,
37+
fileSystem: compiler.inputFileSystem ?? undefined,
3838
});
3939
const webpackOptions = compiler.options;
4040
compiler.hooks.environment.tap(PLUGIN_NAME, () => {

uniqueId

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Thu Mar 21 2024 01:50:45 GMT+0000 (Coordinated Universal Time)
1+
Thu Mar 21 2024 13:34:33 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)