Skip to content

Commit 4dd78b9

Browse files
author
Angular Builds
committed
4243830 refactor(@angular/build): avoid write file logic for internal application build action
1 parent d5b3b37 commit 4dd78b9

File tree

7 files changed

+12
-14
lines changed

7 files changed

+12
-14
lines changed

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{
22
"name": "@angular-devkit/build-angular",
3-
"version": "18.2.0-next.3+sha-2253957",
3+
"version": "18.2.0-next.3+sha-4243830",
44
"description": "Angular Webpack Build Facade",
55
"main": "src/index.js",
66
"typings": "src/index.d.ts",
77
"builders": "builders.json",
88
"dependencies": {
99
"@ampproject/remapping": "2.3.0",
10-
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#2253957",
11-
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#2253957",
12-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#2253957",
13-
"@angular/build": "github:angular/angular-build-builds#2253957",
10+
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#4243830",
11+
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#4243830",
12+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#4243830",
13+
"@angular/build": "github:angular/angular-build-builds#4243830",
1414
"@babel/core": "7.25.2",
1515
"@babel/generator": "7.25.0",
1616
"@babel/helper-annotate-as-pure": "7.24.7",
@@ -21,7 +21,7 @@
2121
"@babel/preset-env": "7.25.3",
2222
"@babel/runtime": "7.25.0",
2323
"@discoveryjs/json-ext": "0.6.0",
24-
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#2253957",
24+
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#4243830",
2525
"@vitejs/plugin-basic-ssl": "1.1.0",
2626
"ansi-colors": "4.1.3",
2727
"autoprefixer": "10.4.20",

src/builders/browser-esbuild/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ async function* buildEsbuildBrowser(userOptions, context, infrastructureSettings
3333
if (deleteOutputPath && infrastructureSettings?.write !== false) {
3434
await (0, private_1.deleteOutputDir)(context.workspaceRoot, outputPath.base);
3535
}
36-
for await (const result of (0, private_1.buildApplicationInternal)(normalizedOptions, context, {
37-
write: false,
38-
}, plugins && { codePlugins: plugins })) {
36+
for await (const result of (0, private_1.buildApplicationInternal)(normalizedOptions, context, plugins && { codePlugins: plugins })) {
3937
// Write the file directly from this builder to maintain webpack output compatibility
4038
// and not output browser files into '/browser'.
4139
if (infrastructureSettings?.write !== false &&

src/builders/dev-server/builder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function execute(options, context, transforms = {}, extensions) {
7676
return builderName === '@angular-devkit/build-angular:browser-esbuild'
7777
? // eslint-disable-next-line @typescript-eslint/no-explicit-any
7878
buildEsbuildBrowser(options, context, { write: false }, codePlugins)
79-
: buildApplicationInternal(options, context, { write: false }, { codePlugins });
79+
: buildApplicationInternal(options, context, { codePlugins });
8080
}, context, transforms, extensions)));
8181
}
8282
// Warn if the initial options provided by the user enable prebundling with Webpack-based builders

src/builders/jest/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ exports.default = (0, architect_1.createBuilder)(async (schema, context) => {
101101
styles: false,
102102
vendor: false,
103103
},
104-
}, context, { write: false }));
104+
}, context));
105105
if (buildResult.kind === private_1.ResultKind.Failure) {
106106
return { success: false };
107107
}

src/builders/web-test-runner/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ async function buildTests(testFiles, outputPath, options, ctx) {
9595
vendor: true,
9696
},
9797
polyfills,
98-
}, ctx, { write: false }));
98+
}, ctx));
9999
return buildOutput;
100100
}
101101
function extractZoneTesting(polyfills) {

src/utils/normalize-cache.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
1010
exports.normalizeCacheOptions = normalizeCacheOptions;
1111
const node_path_1 = require("node:path");
1212
/** Version placeholder is replaced during the build process with actual package version */
13-
const VERSION = '18.2.0-next.3+sha-2253957';
13+
const VERSION = '18.2.0-next.3+sha-4243830';
1414
function hasCacheMetadata(value) {
1515
return (!!value &&
1616
typeof value === 'object' &&

uniqueId

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Mon Aug 05 2024 22:35:22 GMT+0000 (Coordinated Universal Time)
1+
Tue Aug 06 2024 12:27:27 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)