Skip to content

fix(@angular-devkit/build-angular): IE11 errors when using scripts an… #14951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix(@angular-devkit/build-angular): IE11 errors when using scripts an… #14951

merged 1 commit into from
Jul 2, 2019

Conversation

alan-agius4
Copy link
Collaborator

…d differential loading

Invert the builds so that es2015 scripts output don't override the es5 version.

Fixes #14777

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 1, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva July 1, 2019 08:49
…d differential loading

Invert the builds so that es2015 scripts output don't override the es5 version.

Fixes #14777
@alan-agius4
Copy link
Collaborator Author

Seems like 3rdpartylicenses.txt increased by 11.08KB.

@filipesilva
Copy link
Contributor

caretaker: the size increase in licenses is expected because now it includes all licenses used in es5 bundles, including the extra polyfills.

@vikerman
Copy link
Contributor

vikerman commented Jul 1, 2019

@alan-agius4 - Can you fix the size test. The size change seems ok.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Jul 2, 2019

The size check will be fixed automaticlly once the PR gets merged.

@vikerman vikerman merged commit 8754ecb into angular:master Jul 2, 2019
@alan-agius4 alan-agius4 deleted the ie-11-script-error branch July 2, 2019 18:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 error when build with production option
4 participants