Skip to content

fix(@schematics/angular): set restartOnFileChange to true in karma.conf templates #13630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

confraria
Copy link
Contributor

fix for this issue #13542

@alan-agius4
Copy link
Collaborator

Can you kindly amend the commit message, to include Fix #13542 in the footer?

fix(@schematics/angular): set restartOnFileChange to true in karma.conf templates

Fix #13542

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@filipesilva PTAL.

@confraria confraria force-pushed the schematics-fix-karma-restart-on-file-change branch from 64cd808 to 0ad489d Compare February 8, 2019 19:42
@confraria
Copy link
Contributor Author

confraria commented Feb 8, 2019

@alan-agius4 commit msg amended ✅

@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Feb 9, 2019
@alexeagle alexeagle merged commit 1f9c84f into angular:master Feb 9, 2019
@confraria confraria deleted the schematics-fix-karma-restart-on-file-change branch February 9, 2019 17:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants