From 67fd8419e866f5270382304082eb7d1b44f05d41 Mon Sep 17 00:00:00 2001
From: Alan Agius <alan.agius4@gmail.com>
Date: Sat, 19 Jan 2019 18:59:38 +0100
Subject: [PATCH] fix(@angular/cli): schematics commands should fail on unknown
 options

When an addition argument is parsed the schematic commands should fail with an error.

Fixes #12549
---
 packages/angular/cli/models/schematic-command.ts      | 9 +++++++++
 tests/legacy-cli/e2e/tests/commands/unknown-option.ts | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/packages/angular/cli/models/schematic-command.ts b/packages/angular/cli/models/schematic-command.ts
index ded5925dfab8..833026d30b8f 100644
--- a/packages/angular/cli/models/schematic-command.ts
+++ b/packages/angular/cli/models/schematic-command.ts
@@ -437,6 +437,15 @@ export abstract class SchematicCommand<
       args = await this.parseArguments(schematicOptions || [], o);
     }
 
+    // ng-add is special because we don't know all possible options at this point
+    if (args['--'] && schematicName !== 'ng-add') {
+      args['--'].forEach(additional => {
+        this.logger.fatal(`Unknown option: '${additional.split(/=/)[0]}'`);
+      });
+
+      return 1;
+    }
+
     const pathOptions = o ? this.setPathOptions(o, workingDir) : {};
     let input = Object.assign(pathOptions, args);
 
diff --git a/tests/legacy-cli/e2e/tests/commands/unknown-option.ts b/tests/legacy-cli/e2e/tests/commands/unknown-option.ts
index cc1e994dbae9..220d74bc1646 100644
--- a/tests/legacy-cli/e2e/tests/commands/unknown-option.ts
+++ b/tests/legacy-cli/e2e/tests/commands/unknown-option.ts
@@ -15,4 +15,13 @@ export default async function() {
     [ 'build', '--notanoption' ],
     /should NOT have additional properties\(notanoption\)./,
   ));
+
+  const ngGenerateArgs = [ 'generate', 'component', 'component-name', '--notanoption' ];
+  await expectToFail(() => ng(...ngGenerateArgs));
+
+  await execAndWaitForOutputToMatch(
+    'ng',
+    ngGenerateArgs,
+    /Unknown option: '--notanoption'/,
+  );
 }