Skip to content

Setup Windows CI #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IgorMinar opened this issue Dec 5, 2015 · 4 comments
Closed

Setup Windows CI #92

IgorMinar opened this issue Dec 5, 2015 · 4 comments

Comments

@IgorMinar
Copy link
Contributor

We should setup appveyor or something similar to run an e2e test on windows. Travis does not support windows VMs.

http://www.appveyor.com/docs/lang/nodejs-iojs

Once setup we should use it to run end-to-end test suite: #90

@jkuri
Copy link
Contributor

jkuri commented Mar 4, 2016

I successfully configured the Windows CI.
I must say that appveyor works fine, the only problem is that builds are not running concurrently and the build time exceeds 20min as I configured x86 and amd64 arch for both node versions. Otherwise appveyor really is a Travis CI for Windows environment as they are saying on their webpage. If we use their plan then 2 concurrent jobs are guaranteed, I think, and then build time will be similar to the one we now have in Travis CI.
Here is the history of my test builds and here is the configuration I used.

/cc @hansl

@hansl
Copy link
Contributor

hansl commented Mar 4, 2016

Good job! It's really nice to see this.

Look at the results, there's absolute no reason why we should run both x86b and x64 versions of the CLI tests. Also, we could be more severe with Windows and not run the tests on Node 4, telling people they need node 5 or above for better support.

Let's chat on Slack for the next steps with this (ie. submitting it to the repo and making it required for PRs to get green).

@hansl
Copy link
Contributor

hansl commented Mar 10, 2016

I can close this now. This was done with PR #275. Thanks jkuri!

@hansl hansl closed this as completed Mar 10, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants