-
Notifications
You must be signed in to change notification settings - Fork 12k
Build breaks on Windows with ~ font paths relative to node_modules (working on OSX/Linux) #9154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fixed via #9077 and will be in next release. |
@clydin Seems that your fix have broken something else 😭 : https://travis-ci.org/ngx-rocket/generator-ngx-rocket/jobs/327635323 This one was working with |
Unrelated actually; imports and url()s are handle differently. Apparently webpack doesn’t automatically resolve with the tilde. You can actually remove the tilde to remove the error. Next patch release will fix the tilde issue in imports. |
Not really, I already tried to replace the |
@clydin On a Windows 10 OS, you could produce the same error running |
@clydin After merging my fork with Master, tests pass. Thanks. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions
Repro steps
When using Sass and a lib that includes fonts, like FontAwesome, override the font path variable to a tilde-based one like this:
Here is a repository to reproduce the bug: https://github.com/ngx-rocket/starter-kit/tree/cli-bug-tilde
cli-bug-tilde
branchnpm install
npm start
Observed behavior
On Windows, the build process breaks badly with Sass when font paths variables use
~
for paths relative tonode_modules
folder. Same projects builds fine on OSX or Linux.Here is the complete error (I omitted the warnings of postcss-loader, see #8781 (comment)):
Desired behavior
Build works without issue.
Mention any other details that might be useful (optional)
May be related to the fix of #8781 (comment)
Working on
angular-cli@~1.5
branch.The text was updated successfully, but these errors were encountered: