Skip to content

@ngtools/webpack: Add ability to directly import an NgFactory #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
franekp opened this issue Sep 19, 2017 · 2 comments
Closed

@ngtools/webpack: Add ability to directly import an NgFactory #7743

franekp opened this issue Sep 19, 2017 · 2 comments
Labels
feature Issue that requests a new feature

Comments

@franekp
Copy link

franekp commented Sep 19, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

All.

Repro steps.

When having any custom bootstrap code, users need to read source of this plugin and structure their code in hacky ways specially to not break bootstrapping code detection.
For example: #3540 (comment)
I recently needed to use NgUpgrade's "independent mode" which requires different bootstrapping (downgradeModule + angular 1 bootstrap code) and had to use a workaround.

The log given by the failure.

ERROR in /home/...../main.ts (36,37): Cannot find module './app.module.ngfactory'.

Desired functionality.

import {MyModuleNgFactory} from './app.module.ngfactory'
// ^ should work without problems

@Brocco Brocco added the feature Issue that requests a new feature label Sep 22, 2017
@hansl hansl removed their assignment Feb 6, 2018
@filipesilva
Copy link
Contributor

This isn't a feature that we're looking at adding. My best advice for this usecase is to use a custom setup. If there's NgUpgrade documentation in angular.io today that asks you to do things that just don't work on Angular CLI we should fix that though.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

4 participants