Skip to content

feat(@angular/cli): specify naming convention for lazy chunks #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CaerusKaru opened this issue Jul 16, 2017 · 7 comments · Fixed by #7007
Closed

feat(@angular/cli): specify naming convention for lazy chunks #6999

CaerusKaru opened this issue Jul 16, 2017 · 7 comments · Fixed by #7007
Assignees
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@CaerusKaru
Copy link
Member

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ x ] feature request

Versions.

@angular/cli: 1.3.0-beta.1
node: 8.1.3
os: linux x64
@angular/animations: 4.3.0
@angular/cdk: 2.0.0-beta.8-abec992
@angular/cli: 1.3.0-beta.1
@angular/common: 4.3.0
@angular/compiler: 4.3.0
@angular/core: 4.3.0
@angular/flex-layout: 2.0.0-beta.8
@angular/forms: 4.3.0
@angular/http: 4.3.0
@angular/material: 2.0.0-beta.8-abec992
@angular/platform-browser: 4.3.0
@angular/platform-browser-dynamic: 4.3.0
@angular/platform-server: 4.3.0
@angular/router: 4.3.0
@angular/app-shell: 0.1.0
@angular/compiler-cli: 4.3.0
@angular/language-service: 4.3.0
@angular/service-worker: 1.0.0-beta.16

Desired functionality.

bcca0d7 changed the way chunks are named. There should be an option to go back to the old naming convention. This allows for finer obfuscation if desired.

Maybe something like --ob-lazy as an option with ng build.

@intellix
Copy link
Contributor

Do you mean that you want to go from: account.module to 0.module to save 6 bytes when it's referenced for loading?

@ubaidazad
Copy link

ubaidazad commented Jul 16, 2017

is bcca0d7 in 4.3.0 ? not mentioned in CHANGELOG.md

@grizzm0
Copy link
Contributor

grizzm0 commented Jul 16, 2017

@ubaidazad You're linking to a commit on AngularCLI repo and CHANGELOG of the Angular repo. That makes no sense. :p The commit you linked to will be in the 1.3 release of AngularCLI.

@CaerusKaru
Copy link
Member Author

CaerusKaru commented Jul 16, 2017

@intellix The naming convention change is correct, but the reason is not. My personal reason for wanting the change is because I don't have the luxury in my dev environment of having semantic control over the files, so obfuscated names are better and cause less conflict. Regardless, I feel like since it was the original implementation, and it doesn't change that much code, allowing this freedom to the developer is a win-win.

@ubaidazad You can find the respective commit referenced here

@CaerusKaru
Copy link
Member Author

Thanks @filipesilva. Currently tracking in #7007

@filipesilva
Copy link
Contributor

Sorry guys I hadn't seen this issue yet, but #7007 does address it fully.

@filipesilva filipesilva self-assigned this Jul 18, 2017
@filipesilva filipesilva added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent feature Issue that requests a new feature labels Jul 18, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants