-
Notifications
You must be signed in to change notification settings - Fork 12k
ng test / e2e fail in 1.1.0 due to mismatch between test and template - inline templates #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We do have tests for exactly this. Let me try to repro. |
I did the following:
All pass. Is there some other step that's missing? |
Yes, sorry, as mentioned in the PR, it's with inline template :
Correcting the PR now. |
@sumitarora can you take a look please? |
@filipesilva I can confirm it's the issue with inline templates. |
Fixed in last releases. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
cli 1.1.0
Repro steps.
Because the new tests doesn't match the app.component template.Because the inline app component template doesn't match the new external one.
I'm doing the PR right now, but shouldn't it have been caught by some test before release ?
The text was updated successfully, but these errors were encountered: