Skip to content

ng test / e2e fail in 1.1.0 due to mismatch between test and template - inline templates #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyrilletuzi opened this issue Jun 1, 2017 · 7 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient type: bug/fix

Comments

@cyrilletuzi
Copy link
Contributor

cyrilletuzi commented Jun 1, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report

Versions.

cli 1.1.0

Repro steps.

  1. ng new app -it
  2. ng e2e > fails
  3. ng test > fails

Because the new tests doesn't match the app.component template.
Because the inline app component template doesn't match the new external one.

I'm doing the PR right now, but shouldn't it have been caught by some test before release ?

@filipesilva
Copy link
Contributor

We do have tests for exactly this. Let me try to repro.

@filipesilva filipesilva self-assigned this Jun 1, 2017
@filipesilva
Copy link
Contributor

I did the following:

ng new v1.1.0-app
cd v1.1.0-app
ng test
ng e2e

All pass. Is there some other step that's missing?

@filipesilva filipesilva added the needs: repro steps We cannot reproduce the issue with the information given label Jun 1, 2017
@cyrilletuzi
Copy link
Contributor Author

Yes, sorry, as mentioned in the PR, it's with inline template :

ng new v1.1.0-app -it
cd v1.1.0-app
ng test
ng e2e

Correcting the PR now.

@filipesilva filipesilva assigned sumitarora and unassigned filipesilva Jun 6, 2017
@filipesilva filipesilva added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient type: bug/fix and removed needs: repro steps We cannot reproduce the issue with the information given labels Jun 6, 2017
@filipesilva
Copy link
Contributor

@sumitarora can you take a look please?

@sumitarora
Copy link
Contributor

@filipesilva I can confirm it's the issue with inline templates.

@sumitarora sumitarora changed the title ng test / e2e fail in 1.1.0 due to mismatch between test and template ng test / e2e fail in 1.1.0 due to mismatch between test and template - inline templates Jun 6, 2017
@cyrilletuzi
Copy link
Contributor Author

Fixed in last releases.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants