Skip to content

Lazy load a ngModule that has been packaged via npm #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miladchamo opened this issue May 12, 2017 · 3 comments
Closed

Lazy load a ngModule that has been packaged via npm #6297

miladchamo opened this issue May 12, 2017 · 3 comments
Labels
needs: investigation Requires some digging to determine if action is needed

Comments

@miladchamo
Copy link

miladchamo commented May 12, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ x] feature request

Versions.

image

Repro steps.

  1. Create an ngModule (feature Module) and publish it to npm.
  2. Install the published module into an angular app that has been created via the angular-cli
  3. try to lazy load the npm installed module/package, This seems to not be supported, as the current syntax for lazy loading expects something like the below, however, the npm installed module is installed into the node_modules folder.
    {path: 'admin', loadChildren:'app/admin/admin.module#AdminModule'},

The log given by the failure.

Desired functionality.

Should be able to lazy load a module/package that has been installed via npm, similar to how we are able to lazy load feature modules that live within our angular application.

Mention any other details that might be useful.

Looks like a similar issue was reported and acknowledged back in October, 2016, but, I haven't seen traction on this issue.
#2601

@sumitarora sumitarora self-assigned this May 15, 2017
@sumitarora sumitarora added the needs: investigation Requires some digging to determine if action is needed label May 15, 2017
@alexciesielski
Copy link

Looks like a similar issue was reported and acknowledged back in October, 2016, but, I haven't seen traction on this issue.

Then why duplicate the issue?

@alan-agius4
Copy link
Collaborator

Thanks for reporting this issue. However, this issue is a duplicate of #2601. Please subscribe to that issue for future updates.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed
Projects
None yet
Development

No branches or pull requests

4 participants