Skip to content

--dry-run for generating service writes import statement and includes service in providers #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kulbhushan18 opened this issue Apr 22, 2017 · 2 comments

Comments

@Kulbhushan18
Copy link

Bug Report or Feature Request (mark with an x)

- [x] bug report -> --dry-run  for generating service writes import statement and includes in providers

Versions.

Output from: `ng --version`.
@angular/cli: 1.0.0
node: 7.0.0
os: win32 x64
@angular/common: 4.0.3
@angular/compiler: 4.0.3
@angular/core: 4.0.3
@angular/forms: 4.0.3
@angular/http: 4.0.3
@angular/platform-browser: 4.0.3
@angular/platform-browser-dynamic: 4.0.3
@angular/router: 4.0.3
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.3

 Windows (10)

Repro steps.

  • ng g s core\exception -m core\core.module -d
  • commands run:
    • ng new APP -sg -sc -r
    • ng g c home
    • ng g m core
    • ng g s core\exception -m core\core.module -d

The log given by the failure.

No log generated, but following is the output of command

installing service
You specified the dry-run flag, so no changes will be written.
  create src\app\core\exception.service.spec.ts
  create src\app\core\exception.service.ts
  update src\app\core\core.module.ts

Desired functionality.

--dry-run for generating service should not modify anything

Mention any other details that might be useful.

@sumitarora
Copy link
Contributor

@Kulbhushan18 This has already been addressed and fix is in the master. Will be available with next release. #5862

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants