-
Notifications
You must be signed in to change notification settings - Fork 12k
Support (@angular/*) source maps coming from node_modules #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is the vision to always include source maps for @angular/* or to control this via a flag? |
@Brocco we should always include it unless there is a reason not to in some cases (perf?) |
Removing this from the 1.0 BLOCKING. In an hello world program, this adds 6 seconds to the build time, so we will be punting this to 1.x with a design phase. The solution will be to have the |
Is this something that you would be interested in a community contribution to fix? Our use case is a little bit different than the title of this issue, but we have our own library source maps we would like to get included during builds. |
is support for source maps from node_modules 3rd party libs coming anytime soon? I've got the same driver for this as @drstanic |
Any updates on this? |
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version. If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. This is at the moment supported via |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
Repro steps.
ng build
,ng serve
orng build --prod --sm
The log given by the failure.
no errors
Desired functionality.
the source maps coming from
@angular/*
packages should be used as input source maps into the build and passed through all the way to the final bundles, so that I can openvendor
bundle usingsource-map-explorer
and see angular typescript files in there.Mention any other details that might be useful.
I can work around this by manually removing the exclude rule from webpack-configs/common.ts but then I hit #5476
The text was updated successfully, but these errors were encountered: