Skip to content

Deep import references - not yarn friendly #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderVangelov opened this issue Feb 23, 2017 · 3 comments
Closed

Deep import references - not yarn friendly #4968

AlexanderVangelov opened this issue Feb 23, 2017 · 3 comments

Comments

@AlexanderVangelov
Copy link

Is there any chance to avoid deep import references, so the cli will be yarn compatible?

For example the following code tasks/e2e.ts#L43:
// webdriver-manager can only be accessed via a deep import from within // protractor/node_modules. A double deep import if you will. const webdriverUpdate = requireProjectModule(projectRoot, 'protractor/node_modules/webdriver-manager/built/lib/cmds/update');

is raising:
Error: Cannot find module 'protractor/node_modules/webdriver-manager/built/lib/cmds/update'
(yarn keeps only the .bin cmd refs inside protractor/node_modules/)

Thank you.

@cacogr
Copy link

cacogr commented Feb 24, 2017

related #4597

@filipesilva
Copy link
Contributor

Fixed by #4597

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants