ng lint problems with formatted output

[moritz-h]

OS?

Ubuntu 16.04

Versions.

@angular/cli: 1.0.0-beta.32.3
node: 6.9.5
os: linux x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-beta.32.3
@angular/compiler-cli: 2.4.8

Repro steps.

ng new cli-project
add some lint errors (i added spaces to src/main.ts)
ng lint --format pmd
ng lint --format checkstyle

The log given by the failure.

Output for pmd:

<pmd version="tslint">
  <file name="src/main.ts">
    <violation begincolumn="26" beginline="1" priority="1" rule="Too many spaces before &#39;from&#39;"> </violation>
  </file>
</pmd>
<pmd version="tslint"></pmd>

Error is extra <pmd version="tslint"></pmd> at the end.

Output for checkstyle:

<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
  <file name="src/main.ts">
    <error line="1" column="26" severity="warning" message="Too many spaces before &#39;from&#39;" source="failure.tslint.import-spacing" />
  </file>
</checkstyle>
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3"></checkstyle>

Error is extra <?xml version="1.0" encoding="utf-8"?><checkstyle version="4.3"></checkstyle> at the end.

Mention any other details that might be useful.

Edit: I looked through the code and found the source of the error:
In .angular-cli.json multiple lintConfigs could be defined (by default 2):
https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng2/files/angular-cli.json#L37-L44

Here a new linter instance is created within the foreach loop of the lintConfigs:
https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/tasks/lint.ts#L40-L48

So each new instance adds a new header for the output file. This is no problem for normal text output, but for XML output it crashes the result.

And unfortunately the creation of a new linter depends on the lintConfigs, otherwise i could have made a simple pull request just moving the linter creation outside the loop.

---

Thanks! We'll be in touch soon.

[moritz-h]

Is fixed now: c99cf96

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}