-
Notifications
You must be signed in to change notification settings - Fork 12k
@ngtools/webpack v1.2.9 doesn't produce factories for lazy routes #4637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 |
Could you provide us with an example repo we can use to investigate? |
If it can be helpful in solving this (to my team it would be for sure) we have a mini sample project with angular 4.1.1, @ngtools/webpack 1.3.1, webpack 2.2.1, typescript 2.3.2. It currently builds fine but shows the dreaded That is not using full angular-cli, only @ngtools/webpack. The readme shows how to launch the usual npm commands. HTH EDIT: At branch jit-entry-point there's also a version where the JiT entry point is used, instead of the AoT one coming from past ngc experience. |
Having same problem, but got this with |
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version. If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. |
@filipesilva Just to get a better understanding: we have this same issue without using Angular CLI, just with ngtools/webpack 1.3.1. I got that angular team solved the issue with a new Angular CLI version, but keeping the same ngtools/webpack. Does that mean the issue resides outside of ngtools/webpack ? |
@GiuseppePiscopo I really can't tell at this point, it's better to open a new issue with updated versions so we can investigate. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Hi,
Updating to version 1.2.9 from 1.2.8 broke lazy loaded components using routes.
In the previous version, webpack produced separate chunk for each lazy route as expected.
In the current version, same process didn't produce the chunks.
OS?
Versions.
The log given by the failure.
Mention any other details that might be useful.
The text was updated successfully, but these errors were encountered: