Skip to content

When saving multiple files changes at the same time, "ng serve" can't detect part of the files. #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
owen26 opened this issue Feb 10, 2017 · 3 comments

Comments

@owen26
Copy link

owen26 commented Feb 10, 2017

OS?

Mac OSX El Capitan

Versions.

angular-cli: 1.0.0-beta.26
node: 6.9.1
os: darwin x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/material: 2.0.0-beta.1
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/compiler-cli: 2.4.6

Repro steps.

  1. Use any IDE that have "save all files" feature. (I use WebStorm);
  2. Save all your existing file changes, run ng serve;
  3. Open homepage in browser, see the browser console is clean;
  4. Insert console.log() in multiple files but do not save the files yet. eg.
console.log('app update 1'); // app.module.ts
console.log('layout update 1'); // layout.module.ts
console.log('home update 1'); // home.module.ts
  1. Save all files at once in your IDE, then check browser console outputs;
  2. See browser console only one line output app update 1, without the other 2;
  3. Update all 3 files again to print update 2
  4. Observe browser console now output update 2 from one file, update 1 another file, and no output from the last file.
@filipesilva
Copy link
Contributor

This was fixed in #4542, released in beta.31.

It was actually quite hard to track down this problem, and it was exactly what you described. Wish we had known sooner!

@owen26
Copy link
Author

owen26 commented Feb 10, 2017

Glad to hear it has been solved, thanks a lot!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants