-
Notifications
You must be signed in to change notification settings - Fork 12k
Deploying to github pages with custom domain is not working correctly #4127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I too am having this same issue. It appears to me that it needs to maintain the |
The CLI could check for the presence of a CNAME file in the repository, and when one is detected, do not modify the base tag. UPDATE: SOLUTION: I'm not sure if there is a way to configure the custom domain in the Additionally, after updating to Beta 26 I had to remove my local |
I can confirm that it works with angular-cli version 1.0.0-beta.26. I still believe that there should be a better way. GitHub looks at the CNAME file, why can't the CLI? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
You still need to define repository name to get app deployed but in such case you wouldn't want to have that name as absolute path of your application.
""
in index.html should become
"<base href="{{ REPOSITORY NAME or "/" if custom domain is enabled }}">"
OS?
Versions.
angular-cli: 1.0.0-beta.25.5
node: 7.3.0
os: win32 x64
Repro steps.
The log given by the failure.
Application tries to load component files using such link structure:
{{ Custom domain}}/{{ Repository name }}/{{ Rest of the path to the component files }}
(I did bold out the problematic part)
Mention any other details that might be useful.
The text was updated successfully, but these errors were encountered: