Skip to content

Get rid of node-zopfli dependency #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva opened this issue Dec 22, 2016 · 3 comments
Closed

Get rid of node-zopfli dependency #3709

filipesilva opened this issue Dec 22, 2016 · 3 comments
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@filipesilva
Copy link
Contributor

We currently depend on node-zopfli but don't really use it and, even though it's optional, it will always try be rebuild itself.

This at best slows down installs and at worst can result in hard to debug failed installs on some systems. This seems to be due to the system actually being able to compile the package natively, but failing somewhere and leaving the npm install with missing packages.

@filipesilva filipesilva added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Dec 22, 2016
@filipesilva filipesilva self-assigned this Dec 22, 2016
@hansl
Copy link
Contributor

hansl commented Dec 22, 2016

Dupe of #3199

@hansl
Copy link
Contributor

hansl commented Dec 22, 2016

Fixed by #3414

@hansl hansl closed this as completed Dec 22, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

No branches or pull requests

2 participants