Skip to content

Need to change bootstrap-sass' icon-font-path to customize #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asfernandes opened this issue Dec 13, 2016 · 3 comments
Closed

Need to change bootstrap-sass' icon-font-path to customize #3537

asfernandes opened this issue Dec 13, 2016 · 3 comments
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@asfernandes
Copy link

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Ubuntu Xenial.

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.22-1
node: 7.2.1
os: linux x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

I can include bootstrap via angular-cli.json by styles:

"styles": [
  "../node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss",
  "../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_theme.scss",
  "styles.scss"
]

But in this way I can't customize it (for example to change font-family-sans-serif). Then I removed the angular-cli.json bootstrap entries and put in styles.scss:

$icon-font-path: '../node_modules/bootstrap-sass/assets/fonts/bootstrap/';
$font-family-sans-serif: Tahoma;
$font-size-base: 8pt;

@import '../node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss';
@import '../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_theme.scss';

The problem is that change to icon-font-path should not be needed but currently is.

@filipesilva filipesilva added command: build P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix needs: investigation Requires some digging to determine if action is needed labels Dec 30, 2016
@filipesilva
Copy link
Contributor

Yeah you shouldn't need to specify the font path just because you're importing it from a scss file. Sounds like a bug.

@filipesilva
Copy link
Contributor

filipesilva commented May 22, 2017

I seem to remember from another issue (#5213) that this is actually intended as per how SASS works.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

2 participants