Skip to content

Don't create typings.d.ts by default #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnpapa opened this issue Dec 3, 2016 · 5 comments · Fixed by #3423
Closed

Don't create typings.d.ts by default #3372

johnpapa opened this issue Dec 3, 2016 · 5 comments · Fixed by #3423

Comments

@johnpapa
Copy link
Contributor

johnpapa commented Dec 3, 2016

OS?

Mac OSX Sierra

Versions.

angular-cli: 1.0.0-beta.21
node: 6.9.1
os: darwin x64

Repro steps

ng new foo

Notice the typings.d.ts file is created by default. it is empty.

Suggestion

  1. Do not create typings.d.ts since it is empty
  2. Add a command for creating an empty file ... see issue here
@digimax
Copy link

digimax commented Dec 3, 2016

Perhaps it would be more useful to provide a link to the typings project, specifically the examples section. If you are coming from JS, and trying to get with the TS program, you best be learning how the darn typings command works.

@johnpapa
Copy link
Contributor Author

johnpapa commented Dec 3, 2016

Adding a link to docs about typings could be helpful, especially since typings have evolved so much over the past year (tsd --> typings --> @types).

However my request was more about the empty file, which some projects may not need. Once we need the file, we can add it. I prefer the CLI to create the files I need, and leave it to me to create the ones I may need.

@samuelrobertson
Copy link

I think this is inconsistent behavior and may surprise users. For example, styles.css is empty. Most users need it. The ones that don't can delete it.

@samuelrobertson
Copy link

Maybe create it empty with a helpful comment or link like John said. Styles.css is created empty with a helpful comment at the top.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants