Skip to content

ng build and serve defaults to AOT #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmansson opened this issue Dec 2, 2016 · 9 comments
Closed

ng build and serve defaults to AOT #3354

tmansson opened this issue Dec 2, 2016 · 9 comments

Comments

@tmansson
Copy link

tmansson commented Dec 2, 2016

OS?

Linux (Ubuntu 16.10)

Versions.

ng version
angular-cli: 1.0.0-beta.22
node: 6.9.1
os: linux x64

Repro steps.

Run ng build, ng build --aot and even ng build -aot. They all produce the same files in the dist folder.

Mention any other details that might be useful.

I noticed this because the update to beta.22 broke my absolute paths in ng build and ng serve, this has before been an issue only when running in AOT-mode.

Also, the build times are now 20 to 30 s. From 2 - 3 s before.

@slubowsky
Copy link

And due to #2496 I am unable to run my application as the workaround fails when using AOT.
I'm sure this will be fixed shortly but right now it seems not to be just a default value issue. I tried --aot=false but it made no difference

@rosslavery
Copy link

rosslavery commented Dec 2, 2016

Can confirm. My app is not AoT ready yet, and I can no longer run ng serve.

Running ng serve --aot=false and ng serve --aot false seems to have no effect either.

Edit: Had to downgrade for now. No matter what configs I hacked around with, couldn't get AoT to turn off.

@kylecordes
Copy link

I have also observed that many of our applications don't yet work on AOT, and am surprised to see AOT as the default before is more robust. (Making AOT default eventually is of course a wonderful idea, really looking forward to it.)

@rosslavery
Copy link

I get the feeling it wasn't meant to be enabled by default, especially since the flag seems to be having no impact on whether AoT is used or not.

Hoping for a hotfix either way, as I'd like the speed improvements of beta 22 without the brokenness of AoT :D

@clydin
Copy link
Member

clydin commented Dec 2, 2016

It should be using the AoT plugin but skipping the code generation step (no ngfactory generation). So any issues with the plugin's typescript compilation are now present in either mode.

@hansl
Copy link
Contributor

hansl commented Dec 2, 2016

Using experimental builds is at your own risks. We're aware of some performance reasons, that's why beta 22 is not released entirely and still tagged experimental.

@hansl hansl closed this as completed Dec 2, 2016
@tmansson
Copy link
Author

tmansson commented Dec 3, 2016

The changelog has no indication that this was an experimental release.

The issue here does not regard performance, but rather that it prevents usage unless the application supports AOT.

For myself, I'll continue using this release. But I'd rather this issue not be closed, since it needs to be fixed. If it's been fixed, I'll also like to know about it.

@angular angular locked and limited conversation to collaborators Dec 4, 2016
@naomiblack
Copy link
Contributor

I've deleted comments on this issue that were in violation of Angular's Code of Conduct and banned the user in question.

@hansl
Copy link
Contributor

hansl commented Dec 5, 2016

@bialad we were in the process of releasing the Beta.22 when we discovered an issue that needed investigation, so we kept the Beta.22 in the experimental tag. The official Beta.22-1 has been released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants