-
Notifications
You must be signed in to change notification settings - Fork 12k
ng build and serve defaults to AOT #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
And due to #2496 I am unable to run my application as the workaround fails when using AOT. |
Can confirm. My app is not AoT ready yet, and I can no longer run Running Edit: Had to downgrade for now. No matter what configs I hacked around with, couldn't get AoT to turn off. |
I have also observed that many of our applications don't yet work on AOT, and am surprised to see AOT as the default before is more robust. (Making AOT default eventually is of course a wonderful idea, really looking forward to it.) |
I get the feeling it wasn't meant to be enabled by default, especially since the flag seems to be having no impact on whether AoT is used or not. Hoping for a hotfix either way, as I'd like the speed improvements of beta 22 without the brokenness of AoT :D |
It should be using the AoT plugin but skipping the code generation step (no ngfactory generation). So any issues with the plugin's typescript compilation are now present in either mode. |
Using experimental builds is at your own risks. We're aware of some performance reasons, that's why beta 22 is not released entirely and still tagged experimental. |
The changelog has no indication that this was an experimental release. The issue here does not regard performance, but rather that it prevents usage unless the application supports AOT. For myself, I'll continue using this release. But I'd rather this issue not be closed, since it needs to be fixed. If it's been fixed, I'll also like to know about it. |
I've deleted comments on this issue that were in violation of Angular's Code of Conduct and banned the user in question. |
@bialad we were in the process of releasing the Beta.22 when we discovered an issue that needed investigation, so we kept the Beta.22 in the |
OS?
Linux (Ubuntu 16.10)
Versions.
ng version
angular-cli: 1.0.0-beta.22
node: 6.9.1
os: linux x64
Repro steps.
Run
ng build
,ng build --aot
and evenng build -aot
. They all produce the same files in thedist
folder.Mention any other details that might be useful.
I noticed this because the update to beta.22 broke my absolute paths in
ng build
andng serve
, this has before been an issue only when running in AOT-mode.Also, the build times are now 20 to 30 s. From 2 - 3 s before.
The text was updated successfully, but these errors were encountered: